Skip to content

docs: clarify connector vs. SSO sign-in - #34

Merged
mindymo merged 1 commit into
mainfrom
docs/sso-connector-disambiguation-note
Aug 31, 2026
Merged

docs: clarify connector vs. SSO sign-in#34
mindymo merged 1 commit into
mainfrom
docs/sso-connector-disambiguation-note

Conversation

@mindymo

@mindymo mindymo commented Aug 31, 2026

Copy link
Copy Markdown
Contributor

Summary

Adds a note to the top of the connector doc distinguishing this connector (identity governance sync/provisioning for C1) from signing in to C1 via this provider's SSO. Customers have been conflating the two.

Context

The connector doc and the C1 tenant sign-in flow both involve the same identity provider, but they're unrelated setups (separate app registrations/OAuth clients in most cases). This note links to the specific SSO setup section for this provider so readers land in the right place.

Add a note distinguishing this connector (identity governance sync/provisioning) from signing in to C1 via this provider's SSO, linking to the tenant setup guide. Customers have been conflating the two.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
@github-actions

Copy link
Copy Markdown
Contributor

Connector PR Review: docs: clarify connector vs. SSO sign-in

Blocking Issues: 0 | Suggestions: 0 | Threads Resolved: 0
Criteria: Criteria status: loaded .claude/skills/ci-review.md from trusted base f6252f885525.
Review mode: full
View review run

Review Summary

Scanned the full PR diff for security and correctness: this is a documentation-only change adding a four-line <Note> callout at the top of docs/connector.mdx that distinguishes the JumpCloud connector from JumpCloud SSO sign-in to C1. No Go source, go.mod, go.sum, or config files changed, so the connector implementation, provisioning, pagination, and dependency criteria do not apply. The MDX is well-formed, and the capabilities table, credential steps, and configuration fields on the page are unaffected by the insertion; the docs link target (/product/how-to/qs-set-up-c1#authenticate-with-jumpcloud) lives outside this repository and could not be resolved from here, but nothing in the diff indicates it is wrong. No prior review findings existed and no new issues were found.

Security Issues

None found.

Correctness Issues

None found.

Suggestions

None.

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No blocking issues found.

@mindymo
mindymo merged commit a89a3db into main Aug 31, 2026
8 of 9 checks passed
@mindymo
mindymo deleted the docs/sso-connector-disambiguation-note branch August 31, 2026 23:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant