ci: install baton via get-baton action - #52
Conversation
…releases The standalone conductorone/baton CLI (last release built against baton-sdk v0.8.24) can't read c1z files written by this connector's newer, pebble-store-backed SDK version, so `baton grants`/`baton entitlements` fail with "c1z: invalid file" and mask the real sync assertions behind bogus "no grant" errors. Use ConductorOne/github-workflows/actions/get-baton@v4, which installs the baton binary built from conductorone/baton-sdk releases and stays in step with the SDK version baton-ipa depends on.
Connector PR Review: ci: install baton via get-baton actionBlocking Issues: 0 | Suggestions: 1 | Threads Resolved: 0 Review SummaryThe new commit only deletes the explanatory comment above the Security IssuesNone found. Correctness IssuesNone found. Suggestions
Prompt for AI agents |
| --pattern 'baton-*-linux-amd64.tar.gz' --output baton.tar.gz --clobber | ||
| tar xzf baton.tar.gz | ||
| ./baton --version | ||
| uses: ConductorOne/github-workflows/actions/get-baton@v4 |
There was a problem hiding this comment.
🟡 Suggestion: This commit drops the comment explaining why the get-baton action replaced the conductorone/baton release download (that CLI trails baton-sdk and fails with c1z: invalid file on this connector's output). Without it, the next person hitting a baton install problem in CI has no signal against swapping back to scripts/get-baton.sh, which still downloads that same incompatible release. Consider keeping a one-line version of the rationale here.
Summary
conductorone/baton's latest GitHub release to usingConductorOne/github-workflows/actions/get-baton@v4, which builds thebatonbinary fromconductorone/baton-sdkinstead.baton grants/baton entitlementscall sites from./batontobaton(the action installs to/usr/local/bin).Why
PR #51's CI run (and likely any CI run right now) fails the "Test sync resolves DNs for every resource type" step with
Error: c1z: invalid file. The standaloneconductorone/batonCLI's latest release (v0.4.5) is still built againstbaton-sdk v0.8.24, whilebaton-ipadepends onbaton-sdk v0.25.0. The connector's sync now writes c1z files using the newer pebble-store-backed format, which that old CLI can't parse — so everybaton grants/baton entitlementscall in the assertion step errors out and is misreported as a missing grant.get-batoninstalls abatonbinary built fromconductorone/baton-sdkreleases, so it stays in step with whatever SDK version the connector uses.Test plan