chore: update baton-sdk to v0.18.4 - #93
Conversation
Connector PR Review: chore: update baton-sdk to v0.18.4Blocking Issues: 0 | Suggestions: 0 | Threads Resolved: 0 Review SummaryThe full PR diff was scanned for security and correctness. This is a baton-sdk bump from v0.3.35 to v0.18.4 (go directive to 1.25.2) with ~50 transitive dep updates. The only behavioral source change is the required migration from CredentialOptions to LocalCredentialOptions types (including RandomPassword). This migration is mandatory: the new SDK addAccountManager explicitly rejects the old interface at vendor connectorbuilder/accounts.go:161, and all accessor methods (GetNoPassword, GetRandomPassword, GetLength) exist on the new types. Remaining changes are cosmetic (constant extraction for name/email/asc, whitespace) and a CI switch to go-version-file. No new issues found. Security IssuesNone found. Correctness IssuesNone found. SuggestionsNone. |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Fixes the one breaking change introduced by the jump from v0.3.35: crypto.GenerateRandomPassword now takes *v2.LocalCredentialOptions_RandomPassword instead of *v2.CredentialOptions_RandomPassword. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
- Update AccountManagerLimited implementation to use v2.LocalCredentialOptions
instead of the removed v2.CredentialOptions, fixing "old account manager
interface implemented" runtime error.
- Fix go-lint goconst findings by extracting shared string literals
("asc", "name", "email") into named constants.
- Point ci.yaml's setup-go steps at go-version-file: "go.mod" (and reorder
checkout before install) so CI uses the full go1.25.2 SDK release instead
of the slim auto-downloaded toolchain module, which was missing the
covdata tool needed by -covermode=count.
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
b030843 to
fa75a91
Compare
| go-lint: | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - name: Checkout code |
There was a problem hiding this comment.
this whole file can go away, since its redundant to the verify.yaml via baton-admin but can be another pr later on
2 participants
Summary
github.com/conductorone/baton-sdkfrom v0.3.35 to v0.18.4 (go directive bumped to 1.25.2), pulling in ~50 updated transitive deps (grpc, otel, aws-sdk-v2, sqlite/pebble storage, etc.).crypto.GenerateRandomPasswordnow takes*v2.LocalCredentialOptions_RandomPasswordinstead of*v2.CredentialOptions_RandomPassword(same fields, new wrapper type on a new parent message). Updated the call site inpkg/connector/users.go.Test plan
go build ./...passesgo vet ./...passes--helpandcapabilitiesoutput unchanged (config/field layer unaffected)🤖 Generated with Claude Code