-
Notifications
You must be signed in to change notification settings - Fork 0
[CXH-2211] feat: add clm_workflow_queue resource type #67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
51 commits
Select commit
Hold shift + click to select a range
d950095
feat: add clm_workflow_queue resource type (Pylon #11836)
FeliLucero1 2ede60c
fix: address deep-code-review findings on clm_workflow_queue
FeliLucero1 3319a9c
fix: address current bot review findings on PR #67
FeliLucero1 39745ec
fix: address incremental bot review findings on PR #67
FeliLucero1 3efcf69
fix: don't discard already-discovered queues on a later member's failure
FeliLucero1 4cd2db2
fix: gate escalation on a member ever succeeding, not on membership size
FeliLucero1 58c44e2
fix: escalate NotFound too when nothing has succeeded yet
FeliLucero1 d41585d
fix: require consecutive failures before escalating to account-unavai…
FeliLucero1 0f34430
doc: fix typo and stale sentinel doc after the consecutive-threshold fix
FeliLucero1 9192224
fix: log the below-threshold member skip, matching the post-success one
FeliLucero1 afac0cc
refactor: chunk clm_workflow_queue's member scan across List() calls
FeliLucero1 0c3c19e
fix: session-store-write-failure logs to Debug, not Warn
FeliLucero1 d19d711
fix: drop inaccurate justification in Debug-log comment
FeliLucero1 b6f7c83
fix: drop ticket/review-process references from code comments
FeliLucero1 df9bfbf
fix: address remaining review findings on clm_workflow_queue
FeliLucero1 426f5f9
fix: satisfy gocritic appendAssign on the membership merge
FeliLucero1 d1058d0
doc: drop internal ticket reference from README
FeliLucero1 bf91ba6
doc: fix stranded sentence in README after ticket-reference removal
FeliLucero1 cc23ac1
fix: dedup member merge against a resumed sync's replayed chunk
FeliLucero1 96d31b6
fix: don't double-count escalation counters on a replayed chunk
FeliLucero1 fb44dbc
fix: track the expected next input token instead of the last applied one
FeliLucero1 6afb2a1
fix: detect replay of a scan that completed in a single page
FeliLucero1 d0b92ed
fix: fail loudly instead of skipping gracefully when clm_workflow_que…
FeliLucero1 6c147ce
fix: restore CI coverage for the 5 still-tolerant CLM types, fix doc …
FeliLucero1 95c05ac
fix: guard against an empty member Href, fix stale test cross-references
FeliLucero1 78b175b
fix: give the empty-memberID skip its own counter, drop email from it…
FeliLucero1 98aac01
fix: Debug instead of Warn for skip-and-continue logs; propagate sess…
FeliLucero1 b61b45d
fix: include clm_workflow_queue in includeClm scope gating, describe …
FeliLucero1 f490a9a
fix: correct CLM resource-type count in isOptInFeatureUnavailableErro…
FeliLucero1 0776ee0
fix: use pageToken (not SucceededAtLeastOnce) to gate fail-loud on se…
FeliLucero1 6b36162
fix: correct 5-of-6 wording -- all 6 CLM types register unconditionally
FeliLucero1 0a2afb6
fix: correct helper.go doc -- only 4 CLM types tolerate this error, n…
FeliLucero1 52ff742
fix: correct ci.yaml comment count, add regression test for the false…
FeliLucero1 db761c0
fix: wrap test failure message to satisfy revive line-length-limit
FeliLucero1 3175d6d
fix: use pageToken (not SucceededAtLeastOnce) for the 4th session-sto…
FeliLucero1 5df561e
test: add membership-write hard-fail coverage after first chunk
FeliLucero1 3781191
fix: fail loud when discovery state is missing mid-scan (found == false)
FeliLucero1 0b435e0
test: add coverage for discovery state missing mid-scan (found == false)
FeliLucero1 3a9cb16
fix: document operator recovery for the found==false guard
FeliLucero1 0c00119
test: pin the found==false regression test to its specific error text
FeliLucero1 a956a1c
docs: trim workflow-queue comments and ship capabilities entry
FeliLucero1 2799c6d
docs: restore workflow-queue "why" after builder-doc trim
FeliLucero1 8ed5f36
Merge remote-tracking branch 'origin/main' into clm-workflow-queue-su…
FeliLucero1 cf14846
refactor: model clm_workflow_queue as ChildResourceType of clm_member
FeliLucero1 a73fbae
fix: gate clm_member grants on workflow queue opt-in
FeliLucero1 60f713f
refactor: drop unused parent param from parseIntoClmWorkflowQueueReso…
FeliLucero1 78f6808
test: pin includeClm and includeWorkflowQueues derivation in New()
FeliLucero1 9012d60
fix: no-op unparented List for child-only clm_workflow_queue
FeliLucero1 98a20f2
fix: address Sergio review nits on workflow queue sync
FeliLucero1 ab49815
fix: use Debug log for clm_workflow_queue without clm_member
FeliLucero1 e0f316e
fix: address open review items on clm_member and CLM URLs
FeliLucero1 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.