CXH-2350: surface workspace-token sync limits and fix PAT setup docs - #57
CXH-2350: surface workspace-token sync limits and fix PAT setup docs#57al-conductorone wants to merge 1 commit into
Conversation
Connector PR Review: CXH-2350: surface workspace-token sync limits and fix PAT setup docsBlocking Issues: 0 | Suggestions: 0 | Threads Resolved: 0 Review SummaryScanned the full PR diff for security and correctness: it touches Security IssuesNone found. Correctness IssuesNone found. SuggestionsNone. |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| // Account plane down (always under token auth, possible under OAuth) silently drops | ||
| // account entitlements/grants and re-parents identities onto workspaces; surface it. | ||
| if !isAccAPIAvailable && isWSAPIAvailable { | ||
| ctxzap.Extract(ctx).Warn( |
There was a problem hiding this comment.
nit: can we make this Debug instead of Warn? same message is fine — just drop the level. README that says it logs a warning should match.
| // Account plane down (always under token auth, possible under OAuth) silently drops | ||
| // account entitlements/grants and re-parents identities onto workspaces; surface it. | ||
| if !isAccAPIAvailable && isWSAPIAvailable { | ||
| ctxzap.Extract(ctx).Warn( |
There was a problem hiding this comment.
it is not actually visible for customers if i'm not wrong... should we return an error here? it is something to fix on the customer ends to avoid this situation?
4 participants
Workspace-token (PAT) syncs now log a startup warning that account-level access is not covered, so a switch to PAT no longer silently drops data from access reviews. Also fixes the PAT setup example, which previously could not start, and corrects the workspace/token pairing instructions.