docs: add Billing Accounts capability and OAuth scopes (CXP-455) - #37
docs: add Billing Accounts capability and OAuth scopes (CXP-455)#37carolinaroncaglia wants to merge 3 commits into
Conversation
|
Claude finished @carolinaroncaglia's task in 1m 20s —— View job PR Review: docs: add Billing Accounts capability and OAuth scopes (CXP-455)
Overall: Looks good! This is a clean, well-scoped docs update. The changes are clear and the OAuth scope guidance is structured well. I left two inline comments:
Neither is blocking — the docs are accurate and useful as-is. |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| **If you also want to sync and provision Account Groups, add:** | ||
| **If you also want to sync and provision Account Groups or Billing Accounts, add:** | ||
| - core.accounting.read | ||
| - core.accounting.write (required for Billing Account provisioning) |
There was a problem hiding this comment.
Nit: "Billing Account" (singular) here vs "Billing Accounts" (plural) used everywhere else in this PR. Consider making it consistent:
| - core.accounting.write (required for Billing Account provisioning) | |
| - core.accounting.write (required for Billing Accounts provisioning) |
|
|
||
| ¹ Account Groups sync is opt-in. To enable it, select **Account Groups** in the resource types to sync when configuring the connector in C1, and ensure the `core.accounting.read` OAuth scope is added to your Coupa OAuth client. | ||
|
|
||
| ² Billing Accounts sync requires the `core.accounting.read` OAuth scope. Provisioning (grant/revoke) additionally requires the `core.accounting.write` OAuth scope. |
There was a problem hiding this comment.
The Account Groups footnote (¹) mentions that sync is opt-in and tells users to select the resource type in C1. Is Billing Accounts also opt-in? If so, it would be helpful to add similar guidance here (e.g., "To enable it, select Billing Accounts in the resource types to sync…"). If it syncs by default (whenever the scope is present), then the current wording is fine — but it might be worth stating that explicitly to distinguish it from Account Groups.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
Claude finished @carolinaroncaglia's task in 1m 14s —— View job PR Review: docs: add Billing Accounts capability and OAuth scopes (CXP-455)
Overall: Looks good. Clean, well-scoped PR with two logical commits — one for the docs and one for the SDK bump. Documentation (
|
| **If you also want to sync and provision Account Groups, add:** | ||
| **If you also want to sync and provision Account Groups or Billing Accounts, add:** | ||
| - core.accounting.read | ||
| - core.accounting.write (required for Billing Account provisioning) |
There was a problem hiding this comment.
Nit: "Billing Account" (singular) is inconsistent with "Billing Accounts" (plural) used everywhere else in this PR.
| - core.accounting.write (required for Billing Account provisioning) | |
| - core.accounting.write (required for Billing Accounts provisioning) |
|
|
||
| ¹ Account Groups sync is opt-in. To enable it, select **Account Groups** in the resource types to sync when configuring the connector in C1, and ensure the `core.accounting.read` OAuth scope is added to your Coupa OAuth client. | ||
|
|
||
| ² Billing Accounts sync requires the `core.accounting.read` OAuth scope. Provisioning (grant/revoke) additionally requires the `core.accounting.write` OAuth scope. |
There was a problem hiding this comment.
The Account Groups footnote (¹) tells users that sync is opt-in and how to enable it. The Billing Accounts footnote (²) only mentions the OAuth scope requirement but is silent on whether it's opt-in or automatic.
If Billing Accounts is also opt-in, consider adding similar guidance:
| ² Billing Accounts sync requires the `core.accounting.read` OAuth scope. Provisioning (grant/revoke) additionally requires the `core.accounting.write` OAuth scope. | |
| ² Billing Accounts sync is opt-in. To enable it, select **Billing Accounts** in the resource types to sync when configuring the connector in C1, and ensure the `core.accounting.read` OAuth scope is added to your Coupa OAuth client. Provisioning (grant/revoke) additionally requires the `core.accounting.write` OAuth scope. |
If it syncs automatically whenever the scope is present, the current wording works — but stating that explicitly would help distinguish it from Account Groups.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
Claude finished @carolinaroncaglia's task in 1m 15s —— View job PR Review: docs: add Billing Accounts capability and OAuth scopes (CXP-455)
Overall: Looks good. Clean, well-scoped docs-only PR. The Capabilities table addition, footnote, and OAuth scope guidance are all clear and well-structured. The SDK bump revert keeps the PR focused on its intent. I left two inline comments (echoing the earlier feedback since neither has been addressed yet):
Neither is blocking — the docs are accurate and useful as-is. |
| **If you also want to sync and provision Account Groups, add:** | ||
| **If you also want to sync and provision Account Groups or Billing Accounts, add:** | ||
| - core.accounting.read | ||
| - core.accounting.write (required for Billing Account provisioning) |
There was a problem hiding this comment.
Nit: "Billing Account" (singular) is inconsistent with "Billing Accounts" (plural) used everywhere else in this PR.
| - core.accounting.write (required for Billing Account provisioning) | |
| - core.accounting.write (required for Billing Accounts provisioning) |
|
|
||
| ¹ Account Groups sync is opt-in. To enable it, select **Account Groups** in the resource types to sync when configuring the connector in C1, and ensure the `core.accounting.read` OAuth scope is added to your Coupa OAuth client. | ||
|
|
||
| ² Billing Accounts sync requires the `core.accounting.read` OAuth scope. Provisioning (grant/revoke) additionally requires the `core.accounting.write` OAuth scope. |
There was a problem hiding this comment.
The Account Groups footnote (¹) explains that sync is opt-in and tells users how to enable it. This footnote only mentions scope requirements but doesn't clarify whether Billing Accounts sync is opt-in or automatic.
If opt-in, consider adding similar guidance:
| ² Billing Accounts sync requires the `core.accounting.read` OAuth scope. Provisioning (grant/revoke) additionally requires the `core.accounting.write` OAuth scope. | |
| ² Billing Accounts sync is opt-in. To enable it, select **Billing Accounts** in the resource types to sync when configuring the connector in C1, and ensure the `core.accounting.read` OAuth scope is added to your Coupa OAuth client. Provisioning (grant/revoke) additionally requires the `core.accounting.write` OAuth scope. |
If it syncs automatically whenever the scope is present, stating that explicitly would help distinguish it from Account Groups.
|
Closing — docs changes will be handled separately once the SDK bump goes through baton-admin. |
1 participant
Summary
core.accounting.readandcore.accounting.writeOAuth scope requirements for Billing AccountsContext
Implements documentation for the new Billing Accounts feature introduced in PR #35 (
feat: add billing accounts sync as entitlements). Billing Accounts allow users in Coupa to be assigned to financial accounts. The connector now supports syncing them as Entitlements and provisioning (grant/revoke) access.Tracked in Linear: https://linear.app/ductone/issue/CXP-455