Harden spawn allowlist path matching - #121
Merged
Merged
Conversation
Require allowed binaries to be absolute canonical paths and deny basename invocations when an allowlist is configured. Canonicalize absolute argv[0] before spawning so the audited path is the executed path. Add daemon coverage for a request-controlled PATH bypass attempt. Co-authored-by: c1-squire-dev[bot] <c1-squire-dev[bot]@users.noreply.github.com>
pquerna
approved these changes
Jun 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--allowed-binariesentries to be absolute executable paths and canonicalize them at daemon startupPATHbypassargv[0]before spawning so the path that passed policy is the path executedshin request-controlledcwd/PATHTests
cargo test -p agent-tui-daemoncargo test -p agent-tui-daemon allowed_binaries_rejects_basename_with_request_controlled_path -- --nocapturecargo test -p agent-tui lazy_spawn_forwards_allowed_binaries_to_daemon -- --nocapturecargo fmt --checkcargo clippy -p agent-tui-daemon -p agent-tui --all-targets -- -D warnings