Skip to content

Mrc src filt inds#1363

Merged
garrettwrong merged 2 commits intodevelopfrom
mrc_src_filt_inds
Feb 10, 2026
Merged

Mrc src filt inds#1363
garrettwrong merged 2 commits intodevelopfrom
mrc_src_filt_inds

Conversation

@garrettwrong
Copy link
Collaborator

Fixes a user reported bug in one (ctf per micrograph) case of comparing MicrographSimulation with Simulation.

Attached are scripts and supporting files that demonstrate the three cases for the user.

micrograph-script-simpler_per-micrograph-ctf.py
micrograph-script-simpler_singleCTF.py
micrograph-script-simpler_per-particle-ctf.py
supporting_files.tgz

@garrettwrong garrettwrong self-assigned this Feb 10, 2026
@garrettwrong garrettwrong added bug Something isn't working support User Support labels Feb 10, 2026
@codecov
Copy link

codecov bot commented Feb 10, 2026

Codecov Report

❌ Patch coverage is 66.66667% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.86%. Comparing base (9de8047) to head (f9c4cc6).
⚠️ Report is 2 commits behind head on develop.

Files with missing lines Patch % Lines
src/aspire/source/micrograph.py 66.66% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1363      +/-   ##
===========================================
- Coverage    90.87%   90.86%   -0.02%     
===========================================
  Files          135      135              
  Lines        14678    14683       +5     
===========================================
+ Hits         13339    13342       +3     
- Misses        1339     1341       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@garrettwrong garrettwrong requested a review from j-c-c February 10, 2026 15:33
@garrettwrong
Copy link
Collaborator Author

@j-c-c , lets get this one reviewed and merged in so we can wrap up with Andy before I leave.

Copy link
Collaborator

@j-c-c j-c-c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@garrettwrong
Copy link
Collaborator Author

Great thanks. Seems like one of the CI jobs having a DNS issue, hopefully just temporarily.

@garrettwrong garrettwrong marked this pull request as ready for review February 10, 2026 19:10
@garrettwrong garrettwrong requested a review from janden as a code owner February 10, 2026 19:10
@garrettwrong garrettwrong merged commit 1910274 into develop Feb 10, 2026
64 of 66 checks passed
@garrettwrong garrettwrong deleted the mrc_src_filt_inds branch February 10, 2026 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working support User Support

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments