Skip to content

Keep CycloneDX namespaces distinct from unscoped packages - #11

Merged
CompleteDotTech merged 1 commit into
mainfrom
fix/namespaced-sbom-components
Oct 26, 2026
Merged

CompleteDotTech merged 1 commit into
mainfrom
fix/namespaced-sbom-components

Conversation

@CompleteDotTech

Copy link
Copy Markdown
Contributor

Carry the OCI inventory Copilot finding across the related SBOM adapter: a CycloneDX component with group @Vendor and name sharp must not be reported as unscoped sharp. Validate group type, skip unsupported namespaced identities and retain traversal of independent nested components. All observations remain unknown/not_tested.

Validation: 73 local synthetic tests pass (three platform skips), including namespace/nesting/malformed-field regressions; deterministic standalone build/checksum and git diff --check pass. Copilot review and exact-head hosted CI required before merge.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

No blocking code findings remain, but the required hosted CI for the exact PR head has not been verified as complete and passing.

No open issues 🎉

What changed in this PR

This PR tightens the offline CycloneDX SBOM adapter so namespaced components are not mistaken for unscoped Sharp or librsvg packages.

Changes:

  • Validate group as text and exclude namespaced identities from unscoped matching while preserving nested-component traversal.
  • Add regression coverage for namespace handling, nesting, and malformed groups.
  • Rebuild the standalone checker, update its checksum, and document namespace behavior.
File Description
test_adapters.py Tests namespace exclusion, nested traversal, and invalid group types.
src/​adapters.py Validates namespaces and restricts unscoped package matching.
sharp_rsvg_rce_check.py Includes the updated adapter in the standalone checker.
SHA256SUMS Updates the standalone checker checksum.
docs/​REFERENCE.md Documents namespace handling and independent nested traversal.

Review effort: Balanced

Copy link
Copy Markdown
Contributor Author

Final validation for 3554903: 73 local unittest cases pass (3 platform skips), generated checker/checksum and diff checks pass. Copilot completed its current-head review with no blocking code findings or unresolved threads. Hosted CI is confirmed SUCCESS on the exact head across Linux, Windows and macOS. Namespace exclusion retains nested traversal and unknown/not_tested classification.

@CompleteDotTech
CompleteDotTech merged commit b4283ed into main Oct 26, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants