Repository navigation
Keep CycloneDX namespaces distinct from unscoped packages - #11
Merged
Merged
Conversation
There was a problem hiding this comment.
🔵 Needs a closer look
No blocking code findings remain, but the required hosted CI for the exact PR head has not been verified as complete and passing.
No open issues 🎉
What changed in this PR
This PR tightens the offline CycloneDX SBOM adapter so namespaced components are not mistaken for unscoped Sharp or librsvg packages.
Changes:
- Validate
groupas text and exclude namespaced identities from unscoped matching while preserving nested-component traversal. - Add regression coverage for namespace handling, nesting, and malformed groups.
- Rebuild the standalone checker, update its checksum, and document namespace behavior.
| File | Description |
|---|---|
test_adapters.py |
Tests namespace exclusion, nested traversal, and invalid group types. |
src/adapters.py |
Validates namespaces and restricts unscoped package matching. |
sharp_rsvg_rce_check.py |
Includes the updated adapter in the standalone checker. |
SHA256SUMS |
Updates the standalone checker checksum. |
docs/REFERENCE.md |
Documents namespace handling and independent nested traversal. |
Review effort: Balanced
Contributor
Author
|
Final validation for 3554903: 73 local unittest cases pass (3 platform skips), generated checker/checksum and diff checks pass. Copilot completed its current-head review with no blocking code findings or unresolved threads. Hosted CI is confirmed SUCCESS on the exact head across Linux, Windows and macOS. Namespace exclusion retains nested traversal and unknown/not_tested classification. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Carry the OCI inventory Copilot finding across the related SBOM adapter: a CycloneDX component with group @Vendor and name sharp must not be reported as unscoped sharp. Validate group type, skip unsupported namespaced identities and retain traversal of independent nested components. All observations remain unknown/not_tested.
Validation: 73 local synthetic tests pass (three platform skips), including namespace/nesting/malformed-field regressions; deterministic standalone build/checksum and git diff --check pass. Copilot review and exact-head hosted CI required before merge.