Skip to content

Reject malformed npm link flags before fixed-version inference - #6

Merged
CompleteDotTech merged 1 commit into
mainfrom
fix/strict-lockfile-link
Oct 24, 2026
Merged

CompleteDotTech merged 1 commit into
mainfrom
fix/strict-lockfile-link

Conversation

@CompleteDotTech

Copy link
Copy Markdown
Contributor

An npm lockfile entry with a falsey non-boolean link value previously retained exact-version evidence and could produce fixed_version_reported. The parser now accepts only boolean link flags when present, so malformed flags make inventory coverage incomplete and block fixed assessments.

Preserves the existing handling of absent, false and true link flags. Adds v1/v2/v3 type-boundary tests and an end-to-end project regression; updates the reference and rebuilds the standalone distribution and checksums. Advisory rules are unchanged.

Validation: Python 3.12 python3.12 -m unittest -v (88 pass), deterministic build check, real CLI help, and git diff --check. Synthetic data only; no target traffic. Hosted CI will be verified independently at the published head before merging.

Closes #5

@CompleteDotTech

CompleteDotTech commented Oct 24, 2026 •

Copy link
Copy Markdown
Contributor Author

Independent review using gpt-6.1-sol, reasoning effort max, at exact head 00db705dbf0df0fb573faedf99386f042acd8122.

The synthetic malformed-link reproduction is resolved: present npm link flags require booleans in v1/v2/v3. A malformed flag now makes inventory incomplete and prevents fixed-version inference. Absent/false/true flag behavior remains intact. Reviewed the source diff, generated executable and checksum changes, reference, tests and issue #5. Advisory boundaries and source analysis are unchanged.

Local Python 3.12 verification: all 88 tests pass; deterministic build/checksum verification, CLI help and git diff --check pass. Hosted commit check-runs independently confirm all 12 checks at this head pass across Python 3.10/3.14 on Linux/Windows/macOS. Runs: https://github.com/completetech-security/next-cache-rce-check/actions/runs/40103474961, https://github.com/completetech-security/next-cache-rce-check/actions/runs/40103478156.

No additional actionable finding in this correction. The separate interruption audit confirms this CLI does not retry a started stdout write. No target traffic occurred; unknown evidence remains unresolved and exploitability stays not_tested. This comment records review rather than a formal approval from the PR author account. Proceeding with the authorized normal SHA-guarded merge.

@CompleteDotTech
CompleteDotTech merged commit 05abb85 into main Oct 24, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Reject non-boolean npm link flags before version assessment

1 participant