-
Notifications
You must be signed in to change notification settings - Fork 0
Feat/add task input #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
iakomus
wants to merge
10
commits into
main
Choose a base branch
from
feat/add-task-input
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
5b16267
fix: update API endpoint
iakomus 324ebb0
feat: lift PUT logic to the App component (turning Task component int…
iakomus 882d43e
feat: move update logic to `useFetch` (and make it generic enough)
iakomus ca57baa
feat: make `updateRequest` async & update method to PATCH
iakomus 9ed7163
feat: include method to add (post) a task
iakomus 58d7d5d
chore: method names housekeeping
iakomus 73d0dd4
feat: include method to add a new task
iakomus 6f01b9a
feat: add controlled form to add a new task
iakomus 999fd08
feat: move input logic into a custom hook
iakomus 780d9dd
feat: move form to its own component
iakomus File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1 @@ | ||
| REACT_APP_API_ENDPOINT=https://dev.jsonplaceholder.typicode.com/todos | ||
| REACT_APP_API_ENDPOINT=https://jsonplaceholder.typicode.com/todos |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,28 @@ | ||
| import { useInput } from '../hooks/useInput'; | ||
|
|
||
| const TaskForm = ({ addTask }) => { | ||
| const [{ task }, update, reset] = useInput({ task: '' }); | ||
|
|
||
| const handleInputChange = (event) => { | ||
| update(event); | ||
| }; | ||
|
|
||
| const handleSubmit = (event) => { | ||
| event.preventDefault(); | ||
| addTask(task); | ||
| reset(); | ||
| }; | ||
|
|
||
| return ( | ||
| <form onSubmit={handleSubmit}> | ||
| <input | ||
| type="text" | ||
| name="task" | ||
| value={task} | ||
| onChange={handleInputChange} | ||
| /> | ||
| </form> | ||
| ); | ||
| }; | ||
|
|
||
| export default TaskForm; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| import { useState } from 'react'; | ||
|
|
||
| export const useInput = (initialValues) => { | ||
| const [input, setInput] = useState(initialValues); | ||
|
|
||
| const update = (event) => { | ||
| setInput((previous) => { | ||
| return { ...previous, [event.target.name]: event.target.value }; | ||
| }); | ||
| }; | ||
|
|
||
| const reset = () => { | ||
| setInput(initialValues); | ||
| }; | ||
|
|
||
| return [input, update, reset]; | ||
| }; |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.