Skip to content

N°9829 - Add unit tests for parent ticket changes#979

Merged
bdalsass merged 3 commits into
developfrom
feature/9829-user-rights-list-profiles-unit-tests
Jul 23, 2026
Merged

N°9829 - Add unit tests for parent ticket changes#979
bdalsass merged 3 commits into
developfrom
feature/9829-user-rights-list-profiles-unit-tests

Conversation

@bdalsass

Copy link
Copy Markdown
Contributor

Base information

Question Answer
Related to a SourceForge thread / Another PR / A GitHub Issue / Combodo ticket? https://support.combodo.com/pages/UI.php?operation=details&class=Bug&id=9829&c[menu]=SearchBugs
Type of change? Tests

Symptom (bug) / Objective (enhancement)

Cover modifications of user profiles done in N°9723

Checklist before requesting a review

  • I have performed a self-review of my code
  • I have tested all changes I made on an iTop instance
  • I have added a unit test, otherwise I have explained why I couldn't
  • Is the PR clear and detailed enough so anyone can understand without digging in the code?

Copilot AI review requested due to automatic review settings July 22, 2026 06:22
@CombodoApplicationsAccount CombodoApplicationsAccount added the internal Work made by Combodo label Jul 22, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds regression coverage for profile resolution after user changes.

Changes:

  • Tests persisted profiles when unrelated fields change.
  • Tests in-memory profiles when profile_list changes.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread tests/php-unit-tests/unitary-tests/core/UserRightsTest.php Outdated
Comment thread tests/php-unit-tests/unitary-tests/core/UserRightsTest.php Outdated
@greptile-apps

greptile-apps Bot commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

This PR adds tests for profile selection after user changes. The main changes are:

  • Covers persisted profiles when only unrelated attributes change.
  • Covers in-memory profiles when profile_list changes.
  • Imports and directly exercises UserRightsProfile.

Confidence Score: 5/5

This looks safe to merge.

  • No blocking issues found in the changed code.

Important Files Changed

Filename Overview
tests/php-unit-tests/unitary-tests/core/UserRightsTest.php Adds focused tests for persisted and in-memory profile-list behavior.

Reviews (1): Last reviewed commit: "N°9829 - Add unit tests for parent ticke..." | Re-trigger Greptile

@bdalsass
bdalsass requested a review from odain-cbd July 22, 2026 06:45
@bdalsass bdalsass added this to the 3.3.0 milestone Jul 22, 2026
@bdalsass
bdalsass merged commit 006dd3d into develop Jul 23, 2026
@bdalsass
bdalsass deleted the feature/9829-user-rights-list-profiles-unit-tests branch July 23, 2026 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

internal Work made by Combodo

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants