Skip to content

N°9827 - Unable to launch check compatibility when a module with bad dependencies is in production-modules#978

Open
Lenaick wants to merge 2 commits into
developfrom
feature/9827-unable-to-launch-check-compatibility-when-a-module-with-bad-dependencies-is-in-production-modules
Open

N°9827 - Unable to launch check compatibility when a module with bad dependencies is in production-modules#978
Lenaick wants to merge 2 commits into
developfrom
feature/9827-unable-to-launch-check-compatibility-when-a-module-with-bad-dependencies-is-in-production-modules

Conversation

@Lenaick

@Lenaick Lenaick commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

N°9827 - Unable to launch check compatibility when a module with bad dependencies is in production-modules

@greptile-apps

greptile-apps Bot commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

This PR updates module compatibility checks when production modules have invalid dependencies. The main changes are:

  • Keeps modules with dependency issues selected in the wizard.
  • Allows changing those modules during forced uninstall.
  • Blocks normal wizard progress while dependency issues remain.
  • Adds tests for installed and non-installed modules in both modes.

Confidence Score: 5/5

This looks safe to merge.

  • The updated expectations resolve the earlier test mismatch.
  • The navigation guard blocks normal progress when dependency issues remain.
  • The added cases cover installed and non-installed modules with forced uninstall enabled.

Important Files Changed

Filename Overview
setup/wizardsteps/WizStepModulesChoice.php Updates dependency flags and wizard navigation behavior for normal and forced-uninstall flows.
tests/php-unit-tests/unitary-tests/setup/WizStepModulesChoiceTest.php Updates checked-state expectations and adds forced-uninstall cases for modules with missing dependencies.

Reviews (3): Last reviewed commit: "Update unit tests" | Re-trigger Greptile

Comment thread setup/wizardsteps/WizStepModulesChoice.php

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates module selection handling for installed modules with invalid dependencies.

Changes:

  • Keeps affected modules selected until forced uninstallation is enabled.
  • Blocks compatibility checks unless uninstallation checks are explicitly disabled.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread setup/wizardsteps/WizStepModulesChoice.php
Comment thread setup/wizardsteps/WizStepModulesChoice.php
Comment thread setup/wizardsteps/WizStepModulesChoice.php
@Lenaick
Lenaick requested a review from odain-cbd July 22, 2026 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

internal Work made by Combodo

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants