Feature/5874 by v-dumas · Pull Request #977 · Combodo/iTop

v-dumas · 2026-07-21T08:37:36Z

Base information

Question	Answer
Related to a Combodo ticket?	N°5874 - Quick create: improvement for newcomer
Type of change?	Enhancement

Objective (enhancement)

User videos of the SaaS platform showed that the initial use of the "Quick create" button was not intuitive.

When starting out, no default value is suggested, and it is unclear what needs to be typed...

Opening the drop-down menu is extremely difficult because the cursor remains in text-insertion mode, making it hard to target the small "down" arrow.

Proposed solution (bug and enhancement)

Rename the "Recent" section to "Most Popular" (consistent with the "Most Relevant" search criteria).
Change the cursor that appears over the small arrow (which opens the drop-down menu) to a pointer or a finger—something indicating a click—rather than the text-input cursor.
Ensure the classes offered to a new user are relevant: Not the first classes in alphabetical order, but the most popular ones (classes with the "popular" category in the data model).

Checklist before requesting a review

I have performed a self-review of my code
I have tested all changes I made on an iTop instance
I have added a unit test, otherwise I have explained why I couldn't
Is the PR clear and detailed enough so anyone can understand without digging in the code?

Change description of parameters and functions Add comments in twig for clarity Add default popular category to UserRequest and FunctionalCI classes Add comments to tests for clarity

Add comments to tests for clarity

Add comments to tests for clarity Add setUp and tearDown methods on tests Add classes on history and popular sections

Rework tests for readability

Fix tests

Hide Popular section when empty

greptile-apps · 2026-07-21T08:40:29Z

Greptile Summary

This PR adds a “Most popular” section to Quick Create. The main changes are:

New configuration for popular and recent result limits.
Popular categories on selected data-model classes.
Permission-filtered popular-class links with recent-item de-duplication.
Updated Quick Create rendering and translations.
Unit tests for popular and recent class handling.

Confidence Score: 4/5

The new popular-class path needs fixes before merging: it exposes an abstract creation target and loses the selected class code.

Selecting FunctionalCI can open creation for a non-instantiable class.
Popular links render an empty or undefined data-class-code.
Permission filtering and dependency compatibility otherwise appear consistent with the surrounding code.

datamodels/2.x/itop-config-mgmt/datamodel.itop-config-mgmt.xml; templates/base/components/quick-create/layout.html.twig

Important Files Changed

Filename	Overview
sources/Application/UI/Base/Component/QuickCreate/QuickCreateHelper.php	Adds permission-filtered popular-class discovery, result limiting, and recent-item de-duplication.
templates/base/components/quick-create/layout.html.twig	Renders popular classes but assigns their links an undefined class-code value.
datamodels/2.x/itop-config-mgmt/datamodel.itop-config-mgmt.xml	Marks the abstract FunctionalCI class as a popular creation target.
tests/php-unit-tests/unitary-tests/sources/Application/UI/Base/Components/QuickCreate/QuickCreateHelperTest.php	Tests popular-class retrieval and removal of classes already present in recent history.
tests/php-unit-tests/composer.lock	Refreshes the PHPUnit dependency tree consistently with the repository PHP requirement.

_{Reviews (1): Last reviewed commit: "N° 5874 - Quick create: improvement for ..." | Re-trigger Greptile}

greptile-apps · 2026-07-21T08:40:34Z

+                </div>
+                <div class="ibo-quick-create--compartment-content ibo-quick-create--popular-classes--content" data-role="ibo-quick-create--compartment-content">
+                        {% for aClass in oUIBlock.GetPopularClasses() %}
+                            <a href="{{ aClass.target_url }}" class="ibo-quick-create--compartment-element" data-role="ibo-quick-create--compartment-element" data-class-code="{{ aQuery.class }}">


Popular Links Lose Class Code

The popular loop defines aClass, but this attribute reads aQuery.class. Each new popular link therefore receives an undefined or empty data-class-code, so code that identifies the selected class from this attribute receives the wrong value.

Suggested change

<a href="{{ aClass.target_url }}" class="ibo-quick-create--compartment-element" data-role="ibo-quick-create--compartment-element" data-class-code="{{ aQuery.class }}">

<a href="{{ aClass.target_url }}" class="ibo-quick-create--compartment-element" data-role="ibo-quick-create--compartment-element" data-class-code="{{ aClass.class }}">

Copilot

Pull request overview

Improves Quick Create by adding commonly used object classes as default suggestions.

Changes:

Adds rights-aware “Most Popular” class suggestions and configuration.
Marks FunctionalCI and UserRequest as popular.
Adds UI rendering, translations, and unit tests.

Reviewed changes

Copilot reviewed 25 out of 26 changed files in this pull request and generated 6 comments.

Show a summary per file

File	Description
`tests/php-unit-tests/unitary-tests/sources/Application/UI/Base/Components/QuickCreate/QuickCreateHelperTest.php`	Tests popular/recent filtering.
`tests/php-unit-tests/composer.lock`	Upgrades PHPUnit dependencies.
`templates/base/components/quick-create/layout.html.twig`	Renders popular classes.
`sources/Application/UI/Base/Component/QuickCreate/QuickCreateHelper.php`	Builds popular class entries.
`sources/Application/UI/Base/Component/QuickCreate/QuickCreate.php`	Exposes popular classes and limits.
`dictionaries/ui/components/quick-create/zh_cn.dictionary.itop.quick-create.php`	Adds Chinese label.
`dictionaries/ui/components/quick-create/tr.dictionary.itop.quick-create.php`	Adds Turkish fallback label.
`dictionaries/ui/components/quick-create/sk.dictionary.itop.quick-create.php`	Adds Slovak fallback label.
`dictionaries/ui/components/quick-create/ru.dictionary.itop.quick-create.php`	Adds Russian label.
`dictionaries/ui/components/quick-create/pt_br.dictionary.itop.quick-create.php`	Adds Portuguese label.
`dictionaries/ui/components/quick-create/pl.dictionary.itop.quick-create.php`	Adds Polish label.
`dictionaries/ui/components/quick-create/nl.dictionary.itop.quick-create.php`	Adds Dutch label.
`dictionaries/ui/components/quick-create/ja.dictionary.itop.quick-create.php`	Adds Japanese fallback label.
`dictionaries/ui/components/quick-create/it.dictionary.itop.quick-create.php`	Adds Italian label.
`dictionaries/ui/components/quick-create/hu.dictionary.itop.quick-create.php`	Adds Hungarian label.
`dictionaries/ui/components/quick-create/fr.dictionary.itop.quick-create.php`	Adds French label.
`dictionaries/ui/components/quick-create/es_cr.dictionary.itop.quick-create.php`	Adds Spanish label.
`dictionaries/ui/components/quick-create/en.dictionary.itop.quick-create.php`	Adds English label.
`dictionaries/ui/components/quick-create/en_gb.dictionary.itop.quick-create.php`	Adds British English label.
`dictionaries/ui/components/quick-create/de.dictionary.itop.quick-create.php`	Adds German label.
`dictionaries/ui/components/quick-create/da.dictionary.itop.quick-create.php`	Adds Danish fallback label.
`dictionaries/ui/components/quick-create/cs.dictionary.itop.quick-create.php`	Adds Czech label.
`datamodels/2.x/itop-request-mgmt/datamodel.itop-request-mgmt.xml`	Marks UserRequest as popular.
`datamodels/2.x/itop-request-mgmt-itil/datamodel.itop-request-mgmt-itil.xml`	Marks ITIL UserRequest as popular.
`datamodels/2.x/itop-config-mgmt/datamodel.itop-config-mgmt.xml`	Marks FunctionalCI as popular.
`core/config.class.inc.php`	Configures popular and history limits.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

+		// Prevent classes in both Popular and Recent to appear twice
+		for($iIdx = 0; $iIdx < count($aHistoryEntries); $iIdx++)
+		{
+			if (($key = array_search($aHistoryEntries[$iIdx]['class'], $aPopularClassesNames)) !== false) {
+				unset($aPopularClassesNames[$key]);
+			}
+		}


+		$aPopularClasses = QuickCreateHelper::GetPopularClasses();
+		$this->AssertPopularClassesMatches(['FunctionalCI'], $aPopularClasses, "");
+	}
+	private function GivenRecentClasses(array $aGivenClasses)


 			</div>
-			<div class="ibo-quick-create--compartment-title" data-role="ibo-quick-create--compartment-title">
+            {# History section #}
+			<div class="ibo-quick-create--compartment-title ibo-quick-create--history-classes--title" data-role="ibo-quick-create--compartment-title">


 			</div>
+            {# Popular classes section #}
+            {% if oUIBlock.GetPopularClasses()|length > 0 %}
+                <div class="ibo-quick-create--compartment-title ibo-quick-create--popular-classes--title" data-role="ibo-quick-create--compartment-title">


+		//die(var_dump($aPopularClassesNames));
+		static::Truncate($aPopularClassesNames, 'quick_create.max_popular_results');


 	}

+	/**
+	 * @see $aMaxPopularClasses


xguiboud added 7 commits November 21, 2024 15:11

N°5874 - Quick create: improvement for newcomer

dc20644

5874

585072a

Change description of parameters and functions Add comments in twig for clarity Add default popular category to UserRequest and FunctionalCI classes Add comments to tests for clarity

5874

44fa082

Add comments to tests for clarity

5874

b9ad9dc

Add comments to tests for clarity Add setUp and tearDown methods on tests Add classes on history and popular sections

N°5874 - Quick create: improvement for newcomer

d16757f

Rework tests for readability

N°5874 - Quick create: improvement for newcomer

e7a3e7d

Fix tests

N° 5874 - Quick create: improvement for newcomer

1eaeeb5

Hide Popular section when empty

Copilot AI review requested due to automatic review settings July 21, 2026 08:37

v-dumas self-assigned this Jul 21, 2026

Copilot started reviewing on behalf of v-dumas July 21, 2026 08:38 View session

greptile-apps Bot reviewed Jul 21, 2026

View reviewed changes

Copilot AI reviewed Jul 21, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Feature/5874#977

Feature/5874#977
v-dumas wants to merge 7 commits into
developfrom
feature/5874

v-dumas commented Jul 21, 2026

Uh oh!

greptile-apps Bot commented Jul 21, 2026

Greptile Summary

Confidence Score: 4/5

Important Files Changed

Uh oh!

Uh oh!

greptile-apps Bot Jul 21, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

	<a href="{{ aClass.target_url }}" class="ibo-quick-create--compartment-element" data-role="ibo-quick-create--compartment-element" data-class-code="{{ aQuery.class }}">
	<a href="{{ aClass.target_url }}" class="ibo-quick-create--compartment-element" data-role="ibo-quick-create--compartment-element" data-class-code="{{ aClass.class }}">

		//die(var_dump($aPopularClassesNames));
		static::Truncate($aPopularClassesNames, 'quick_create.max_popular_results');

Uh oh!

Conversation

v-dumas commented Jul 21, 2026

Base information

Objective (enhancement)

Proposed solution (bug and enhancement)

Checklist before requesting a review

Uh oh!

greptile-apps Bot commented Jul 21, 2026

Greptile Summary

Confidence Score: 4/5

Important Files Changed

Uh oh!

Uh oh!

greptile-apps Bot Jul 21, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants