Repository navigation
feat(tak): let a channel send ATAK messages without the callsign - #1296
Merged
rinchen merged 4 commits intoOct 20, 2026
Merged
Conversation
Every message an ATAK device sends to a channel goes out as "[CALLSIGN] text", so a bot, which looks for its command at the start of the message, never answers one sent from ATAK. Each sending channel now has an Add callsign checkbox, on by default. With it off, the message goes out exactly as typed. It is kept by channel key, like the channel's other settings. Direct messages keep the callsign. A bare send such as "!ping" is text another node may well send too, so the echo guard now only drops a message that could be this radio's own send heard back: MeshCore never hears its own, and Meshtastic's are from this radio's node. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01EHFPfW7vZXpRdR3tBBTX3r
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01EHFPfW7vZXpRdR3tBBTX3r
Contributor
|
Important Review skippedReview was skipped as selected files did not have any reviewable changes. ⛔ Files ignored due to path filters: 16
⚙️ Run configuration
⛔ Files ignored due to path filters: 16
You can disable this status message by setting the Use the checkbox below for a quick retry:
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📝 Walkthrough
Merge Risk: ⚪ Minimal · up to
|
| Check name | Status | Explanation |
|---|---|---|
| Description Check |  |
Check skipped - CodeRabbit’s high-level summary is enabled. |
| Title check | |
The title clearly and concisely describes the main change: allowing a TAK channel to send ATAK messages without the callsign. |
| Docstring Coverage | |
Docstring coverage is 90.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 10 functions across 13 files. |
| Linked Issues check | |
Check skipped because no linked issues were found for this pull request. |
| Out of Scope Changes check | |
Check skipped because no linked issues were found for this pull request. |
✨ Finishing Touches
-
🧪 Generate unit tests (beta)
-
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Every message an ATAK device sends to a channel goes out as
[CALLSIGN] text. A bot looks for its command at the start of the message, so it never answers a command sent from ATAK (found testing #bot through the TAK server).What
noCallsignChannelsin the TAK relay prefs), like the channel's other settings; earlier saved settings read as all on. Direct messages keep the callsign.!pingwould have been dropped. Now only a message that could be this radio's own is dropped: MeshCore channel messages and Meshtastic messages from another node are always passed on.Tests
New tests for the setting, the bare send next to a prefixed one on another radio, the checkbox, and another node's matching message getting through.
🤖 Generated with Claude Code
https://claude.ai/code/session_01EHFPfW7vZXpRdR3tBBTX3r
Summary by CodeRabbit