Skip to content

[UX] Put game file cleanup button to navigation bar #857

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
bagusnl wants to merge 3 commits into
base: main
Choose a base branch
from
Open

[UX] Put game file cleanup button to navigation bar #857

bagusnl wants to merge 3 commits into from
+33 −1

Conversation

@bagusnl
Copy link
Member

@bagusnl bagusnl commented Jan 6, 2026

Main Goal

Makes the feature more accessible and seen by users instead of it being buried inside Quick Settings.

Screenshots
image
image

closes #725

PR Status :

  • Overall Status : Done
  • Commits : Done
  • Synced to base (Collapse:main) : Yes
  • Build status : OK
  • Crashing : No
  • Bug found caused by PR : 0

Templates

Changelog Prefixes 
  **[New]**
  **[Imp]**
  **[Fix]**
  **[Loc]**
  **[Doc]**

@bagusnl
[UX] Put game file cleanup button to navigation bar
94eefb2 
As FileCleanupPage is not really a "page" rather an overlay, we manually invoke the overlay the same way as the QS invokes them and force the NavigationViewControl to select the last item/page back so the UI literally says "nothing happened here"

i havent slept all night because my dumbass brain so help me
@bagusnl bagusnl requested a review from a team January 6, 2026 23:45
@bagusnl bagusnl self-assigned this Jan 6, 2026
@bagusnl bagusnl added Enhancement New feature or request Area: UI/UX Issue labeled for User Interface/eXperience related issue Priority: Low Size: Small labels Jan 6, 2026
sentry[bot]
sentry bot reviewed Jan 6, 2026
View reviewed changes
@bagusnl
Copy link
Member Author

bagusnl commented Jan 7, 2026

shoulda just left it like this fr
image

@bagusnl
Avoid sending error to Sentry twice
6c34fe9 
note to self: SendException already send the exception data to Sentry
yes, i'm the one who made it do that in the first place
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@sentry sentry[bot] sentry[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@bagusnl bagusnl

Labels

Area: UI/UX Issue labeled for User Interface/eXperience related issue Enhancement New feature or request Priority: Low Size: Small

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Request]: Bring Files Clean-up to sidebar

2 participants

@bagusnl