fix: remove incorrect cents-to-dollars conversion in notification email amounts#75
Open
devin-ai-integration[bot] wants to merge 1 commit into
Open
Conversation
…il amounts FormatCurrency() divided the amount by 100 based on a wrong assumption that OrderPlacedEvent.TotalAmount was in cents. The contract sends dollars (decimal), so a $149.99 order displayed as $1.50 in confirmation emails. Also fixes Notification.API.csproj Shared project reference paths (../../Shared -> ../../../Shared) to match the actual directory structure.
Contributor
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Order confirmation emails displayed wrong amounts (e.g., $149.99 order showed as $1.50) because
NotificationRenderer.FormatCurrency()incorrectly divided by 100:// NotificationRenderer.cs private static string FormatCurrency(decimal amount) { - // The OrderPlacedEvent.TotalAmount is transmitted in cents ... - var dollars = amount / 100m; - return dollars.ToString("C2"); + return amount.ToString("C2"); }The comment claimed
OrderPlacedEvent.TotalAmountwas in cents, but the shared contract (Shared.Contracts.Events.OrderPlacedEvent) defines it asdecimal TotalAmount— already in dollars. The division turned149.99into1.4999, which rounded to$1.50.Also fixes
Notification.API.csprojproject reference paths to Shared libraries (../../Shared->../../../Shared) to match the actual directory layout undersrc/.Root Cause Analysis
The bug was introduced during microservice decomposition. The
FormatCurrencymethod was written with an incorrect assumption (documented in a misleading comment) that theTotalAmountfield was transmitted in cents for "floating-point precision" reasons. In reality, theOrderPlacedEventcontract usesdecimal(which has no floating-point precision issues) and transmits the dollar amount directly.Before
After
Link to Devin session: https://partner-workshops.devinenterprise.com/sessions/bf6d422091a1474691a1c26910179d93
Requested by: @alagarrajanm