feat: TDD migration of owners/pets/visits from Angular to React 18#42
Open
devin-ai-integration[bot] wants to merge 5 commits into
Open
feat: TDD migration of owners/pets/visits from Angular to React 18#42devin-ai-integration[bot] wants to merge 5 commits into
devin-ai-integration[bot] wants to merge 5 commits into
Conversation
Tests import components that don't exist yet - expected to fail. Validates owner CRUD, pet management, and visit creation against API contract.
… phase) - Shared API service with axios (baseURL: http://localhost:9966/petclinic/api) - Owner CRUD: list, detail, add, edit with search - Pet management: list, add, edit, delete - Visit creation: add visit to a pet - All 25 RTL+MSW tests passing - npm run build passes - Follows AGENTS.md coding standards (error handling, loading states, a11y)
Contributor
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
- Remove shared mutable state in MSW handlers (use per-test override) - Remove pets:[] from owner update payload (prevents data loss) - Gate empty-state messages behind !error in OwnerList, PetList, VisitList
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test-driven migration of the three interconnected modules (owners, pets, visits) from Angular 16 to React 18 + TypeScript + Vite, living in
react-frontend/.Commit sequence follows Red→Green TDD:
docs/API_CONTRACT.md— documents every REST endpoint (method, URL, shapes, errors) derived from the Angular servicesapi.tsservice implemented to pass all tests (Green phase)Key patterns per
AGENTS.md:src/services/api.tswithbaseURL: http://localhost:9966/petclinic/apiaria-describedbyerror association:ownerId,:petId,:visitIdroute params and return204 No Contentfor DELETEsnpm run build(tsc + vite build) andnpx vitest runboth pass cleanly.Link to Devin session: https://partner-workshops.devinenterprise.com/sessions/9ec58397515f4e96bfb07363545bb706
Requested by: @DhrovS