Phase 3: Upgrade Angular 18 to 19#14
Open
devin-ai-integration[bot] wants to merge 1 commit into
Open
Conversation
- Run ng update schematics for @angular/core@19, @angular/cli@19, @angular/cdk@19, @angular/material@19 - Angular packages upgraded to 19.2.x, Material/CDK to 19.2.x - Schematic added standalone: false to all component decorators (Angular 19 defaults to standalone) - HttpClientModule migration already completed in Phase 2 (no additional changes needed) - All 43 unit tests pass, production build succeeds
Contributor
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Upgrades Angular from v18 to v19 via
ng updateschematics for@angular/core@19,@angular/cli@19,@angular/cdk@19, and@angular/material@19.Dependency version bumps:
@angular/*packages: 18.2.x → 19.2.21@angular/material/@angular/cdk: 18.2.14 → 19.2.19@angular-devkit/build-angular: 18.2.21 → 19.2.24typescript: 5.4.5 → 5.8.3zone.js: ~0.14.10 → ~0.15.1standalone: falseadded to all component/directive decorators:Angular 19 changed the default value of
standalonefromfalsetotrue. Theng updateschematic automatically added explicitstandalone: falseto all 24 component and directive declarations to preserve existing NgModule-based behavior. No functional change — this is purely a compatibility annotation.No additional manual code changes were required. The
HttpClientModule→provideHttpClient()migration was already completed in Phase 2 (PR #13) by the Angular 18 schematic.Production build and all 43 unit tests pass locally.
Review & Testing Checklist for Human
zone.js0.15 runtime behavior — zone.js had a major version bump (0.14 → 0.15). Run the app against the Spring backend and confirm that change detection, async operations, and form interactions (especially datepickers and mat-selects) still work correctly. Zone.js changes can cause subtle runtime issues that unit tests miss.standalone: falsecoverage — The schematic touched all components, but verify no component or directive was missed. A missing annotation would cause that component to be treated as standalone and break its NgModule.@angular-eslintcompatibility — The@angular-eslint/*packages remain at v17.5.3 (not updated in this phase). Runng lintand confirm there are no crashes or false positives from the version mismatch with Angular 19.ng serve, and exercise all CRUD flows (owners, pets, visits, vets, specialties, pet types). Pay special attention to the vet edit form (/vets/:id/edit) which uses route resolvers converted in Phase 2.Notes
standalone: false.Link to Devin session: https://partner-workshops.devinenterprise.com/sessions/010af0d2621c4376ac0819869f987cf9