NM-24: Configure Logback (port log4Net.xml)#8
Closed
devin-ai-integration[bot] wants to merge 1 commit into
Closed
Conversation
Add logback-spring.xml that replicates the rolling file appender from the legacy log4Net.xml configuration: - File output to logFiles/myapp.log with append mode - Size-based rolling policy (10MB max, 5 backup files) - Log pattern with date, thread, level, logger, and message - Console appender enabled for the dev Spring profile
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Ports the legacy
log4Net.xmlrolling file appender configuration fromeShopLegacyMVCSolution/src/eShopLegacyMVC/log4Net.xmlto a Spring Bootlogback-spring.xml.What's configured:
logFiles/myapp.logwith append mode, size-based rolling policy (10MB max file size, 5 backup files)devSpring profile is active%date [%thread] %X{activityId} %-5level %logger - %X{requestInfo}%n%message%n%n— maps the legacy log4net%property{activity}and%property{requestinfo}to Logback MDC keysMapping from log4Net.xml:
file=logFiles\myapp.log<file>logFiles/myapp.log</file>appendToFile=true<append>true</append>rollingStyle=SizeFixedWindowRollingPolicy+SizeBasedTriggeringPolicymaxSizeRollBackups=5<maxIndex>5</maxIndex>maximumFileSize=10MB<maxFileSize>10MB</maxFileSize>Jira: NM-24
Review & Testing Checklist for Human
./mvnw spring-boot:run -Dspring-boot.run.profiles=devand verify console log output appears with the expected patternlogFiles/myapp.logis created and receives log entriesmaxFileSizefor testing)Notes
devprofile already exists inapplication-dev.ymlwith H2 in-memory database configmvn clean compile(Java 21)Link to Devin session: https://partner-workshops.devinenterprise.com/sessions/88a7fd43bf8e468e8661ec22fe7c151e