NM-27: Port CatalogItem entity to JPA#11
Open
devin-ai-integration[bot] wants to merge 1 commit into
Open
Conversation
Map all properties from eShopLegacyMVC CatalogItem.cs: - @id without @GeneratedValue (HiLo handled externally) - Price as BigDecimal with @column(precision=18, scale=2) - @DecimalMin/@DecimalMax for Price range validation - @digits(integer=16, fraction=2) for decimal precision (replaces .NET RegularExpression) - @notblank @SiZe(max=50) on Name - @manytoone @joincolumn for CatalogBrand and CatalogType - @transient for PictureUri - @Min/@max for stock threshold fields - Default pictureFileName = "dummy.png" in constructor
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Ports the
CatalogItementity fromeShopLegacyMVC/Models/CatalogItem.csto a JPA entity ateShopModernizedSpringSolution/src/main/java/com/eshop/modernized/model/CatalogItem.java.Property mappings from .NET → Java:
Id(int)@IdInteger@GeneratedValue— HiLo handled externallyName([Required])@NotBlank @Size(max=50)StringDescriptionPrice(decimal, [Range], [RegularExpression])@NotNull @DecimalMin("0") @DecimalMax("1000000") @Digits(integer=16, fraction=2)BigDecimal@Column(precision=18, scale=2)PictureFileName"dummy.png"in constructorPictureUri@TransientStringCatalogTypeId/CatalogType@ManyToOne @JoinColumnCatalogBrandId/CatalogBrand@ManyToOne @JoinColumnAvailableStock([Range(0,10000000)])@Min(0) @Max(10000000)intRestockThreshold([Range(0,10000000)])@Min(0) @Max(10000000)intMaxStockThreshold([Range(0,10000000)])@Min(0) @Max(10000000)intOnReorder(bool)Validation mapping:
[Required]→@NotBlank/@NotNull,[Range(0,1000000)]→@DecimalMin/@DecimalMax,[RegularExpression]→@Digits(since@Patternonly applies toCharSequence,@Digits(integer=16, fraction=2)enforces the same max-2-decimal-places constraint).Review & Testing Checklist for Human
@Digitsreplacing@Patternfor BigDecimal price)@ManyToOnerelationships toCatalogBrandandCatalogTypeare correctly mapped with@JoinColumncd eShopModernizedSpringSolution && ./mvnw compileNotes
GenerationType.NONEdoes not exist in JPA; omitting@GeneratedValueentirely is the standard way to indicate externally-managed IDs@Patterncannot be applied toBigDecimalin Bean Validation — used@Digits(integer=16, fraction=2)as the idiomatic Java equivalent of the C# regex^\d+(\.\d{0,2})*$catalogTypeId,catalogBrandId) are mapped as read-only (insertable=false, updatable=false) alongside the@ManyToOnerelationships, with setter methods that sync bothLink to Devin session: https://partner-workshops.devinenterprise.com/sessions/63d968161a234c72b753581a3664dcd6