Encrypt Cloud Sync bundles and clarify privacy - #90
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b37f2fb5f2
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 06619449ab
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
What changed\n\n- Cloud Sync now encrypts every eligible shared-workspace bundle client-side with ChaCha20-Poly1305 before upload.\n- The managed relay receives ciphertext and deterministic opaque bundle names only; tampered, renamed, cross-workspace, wrong-key, and legacy plaintext bundles fail closed.\n- Cloud Sync requires a user-held 32-byte workspace key supplied out of band; missing configuration cannot fall back to plaintext.\n- Public privacy copy now accurately distinguishes encrypted sync from readable, opt-in managed compute.\n- Release metadata is updated to 1.2.1.\n\n## Why\n\nThe prior privacy disclosure and commercial capability record disagreed with the intended Cloud Sync boundary. This makes the boundary technically enforced and documents the key-pairing requirement.\n\n## Validation\n\n- python -m pytest tests/test_sync_e2ee.py tests/test_sync_cli.py tests/test_sync_dashboard.py tests/test_commercial_hardening.py tests/test_packaging.py tests/test_ready.py tests/test_update_check.py tests/test_relay_device_credentials.py -q\n- python scripts/check_commercial_manifest.py\n-
uff check engraphis/backends/sync_relay.py engraphis/backends/sync_folder.py scripts/sync.py tests/test_sync_e2ee.py tests/test_sync_cli.py\n- python -m pytest tests/test_sync_e2ee.py -q -rs\n\nThe full suite was also started locally and exceeded the two-minute command window without emitting a failure; GitHub CI is the release gate.