Fix dark theme slider showing wrong status when canceling#407
Open
Fix dark theme slider showing wrong status when canceling#407
Conversation
CodeyBoi
requested changes
Mar 9, 2026
Owner
There was a problem hiding this comment.
I think it, rather than changing Switch behaviour, would be better to have the Switch be a controlled element tied to the colorscheme value, i.e. use the first return value of useState as value in the Switch component and update the colorscheme when changing that value.
Right now the Switch's initial state is still off even if the colorscheme is dark when first entering the page (or refreshing). I think the above suggestion would fix both issues.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.