-
Notifications
You must be signed in to change notification settings - Fork 6
Issues Fixes around OmniScript and VlocityCard deployment #428
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
dattakale86
commented
Feb 6, 2026
- Add support for digital experience bundle deployment
- Fix issue in Flex Vlocity Card deployment
- Add support for labels in flex card LWC
- Add handling to avoid querying non existing objects from org e.g. OmniProcess or OmniUiCard etc.
- Add record activator for non flex Vlocity cards in post deploy
| filepath: string, | ||
| source: string | ||
| }> = compiler.generateLWCFiles(name, card, 'card', null, metaObject); | ||
| }> = await compiler.generateLWCFiles(name, card, 'card', null, metaObject); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of calling getCustomLabelsFromCardDefinition in the flexCardDesignerUtil.ts can you move it into flexCardLwcCompiler.ts. The flexCardDesignerUtil is sourced from the org and will be with SF releases, for ease of updating we should avoid updating it.
| Label?: Record<string, string>; | ||
| } | ||
|
|
||
| interface OmniUiCardRecord { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would be good to also change this Record type to use lowercase properties so it is alligned across the file.
| "typedoc": "^0.28.12", | ||
| "typedoc-plugin-rename-defaults": "^0.7.0", | ||
| "typescript": "`^5.9", | ||
| "typescript": "^5.9", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't noticed when this typo creaped in, thanks for addressing it.
| await this.addBundledSources(file.replace(/-meta\.xml$/ig, '').split('.').shift()!, metadataType); | ||
| } | ||
| else { | ||
| await this.addBundledSources(path.dirname(file), metadataType); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add a test method for this use case? For changes to the package builder I'd like to have test cases which will also prevent the feature from breaking in the future. There is an existing test class that you can extend.
| // Classic metadata package all related files | ||
| await this.addBundledSources(path.dirname(file), metadataType); | ||
| if (metadataType.id === 'experiencebundle' && file.endsWith('-meta.xml')) { | ||
| await this.addBundledSources(file.replace(/-meta\.xml$/ig, '').split('.').shift()!, metadataType); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use this.stripFileExtension(file, 2) to drop .XX-meta.xml
| await this.addSingleSourceFile(fullPath, metadataType, componentName); | ||
| } | ||
| if (file.isDirectory()) { | ||
| await this.addBundledSources(fullPath, metadataType, componentName); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doens't this also flatten nested structures in for example LWC bundles? And is that wanted, how would it affect __test__ folders in LWC bundles?