Skip to content

Conversation

@dattakale86
Copy link
Collaborator

  1. Add support for digital experience bundle deployment
  2. Fix issue in Flex Vlocity Card deployment
  3. Add support for labels in flex card LWC
  4. Add handling to avoid querying non existing objects from org e.g. OmniProcess or OmniUiCard etc.
  5. Add record activator for non flex Vlocity cards in post deploy

@dattakale86 dattakale86 requested a review from Codeneos February 6, 2026 10:31
filepath: string,
source: string
}> = compiler.generateLWCFiles(name, card, 'card', null, metaObject);
}> = await compiler.generateLWCFiles(name, card, 'card', null, metaObject);
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of calling getCustomLabelsFromCardDefinition in the flexCardDesignerUtil.ts can you move it into flexCardLwcCompiler.ts‎. The flexCardDesignerUtil is sourced from the org and will be with SF releases, for ease of updating we should avoid updating it.

Label?: Record<string, string>;
}

interface OmniUiCardRecord {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be good to also change this Record type to use lowercase properties so it is alligned across the file.

"typedoc": "^0.28.12",
"typedoc-plugin-rename-defaults": "^0.7.0",
"typescript": "`^5.9",
"typescript": "^5.9",
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't noticed when this typo creaped in, thanks for addressing it.

await this.addBundledSources(file.replace(/-meta\.xml$/ig, '').split('.').shift()!, metadataType);
}
else {
await this.addBundledSources(path.dirname(file), metadataType);
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a test method for this use case? For changes to the package builder I'd like to have test cases which will also prevent the feature from breaking in the future. There is an existing test class that you can extend.

// Classic metadata package all related files
await this.addBundledSources(path.dirname(file), metadataType);
if (metadataType.id === 'experiencebundle' && file.endsWith('-meta.xml')) {
await this.addBundledSources(file.replace(/-meta\.xml$/ig, '').split('.').shift()!, metadataType);
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use this.stripFileExtension(file, 2) to drop .XX-meta.xml

await this.addSingleSourceFile(fullPath, metadataType, componentName);
}
if (file.isDirectory()) {
await this.addBundledSources(fullPath, metadataType, componentName);
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doens't this also flatten nested structures in for example LWC bundles? And is that wanted, how would it affect __test__ folders in LWC bundles?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants