[feat] tuistory for e2e tests #390
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fix server spawning to use bun next dev -p PORT directly (bun doesnt expand shell variables in npm scripts) - Improve server cleanup to kill child processes on all relevant ports - Add better debugging to waitForServerReady with attempt counts - Fix max mode test assertion to be more robust - Add documentation about server spawning coupling with web dev script - Add inline comment in web/package.json dev script warning about E2E coupling
- Add Additional Slash Commands tests (/init, /bash, /feedback, /referral, /image, /exit) - Add CLI Flags tests (--help, --version, --agent, invalid flags) - Add Keyboard Interactions tests (Ctrl+C, @mentions, backspace, escape) - Add Error Scenarios tests (low credits, invalid commands, edge cases) Total: 30 E2E tests covering CLI functionality
The previous implementation used `docker run --network host` which does not work on Docker Desktop for macOS/Windows. Now uses host pg_isready (if available) with psql fallback for cross-platform support.
E2E tests require Docker and should not run in the standard CI test jobs. Added ! -path "*e2e*" to the find command.
- Add root-level TESTING.md with test taxonomy for CLI/Web/SDK - Rename tuistory tests to descriptive names (full-stack.test.ts, cli-ui.test.ts) - Delete redundant tests (e2e-cli, integration-tmux, tmux-poc) - Add web/src/__tests__/e2e/README.md for Playwright docs - Update all READMEs with correct file references - Remove test:tmux-poc script from cli/package.json
Tests should fail when API key is missing, not silently skip.
Replace describe.skipIf with throwing errors when prerequisites are not met in CLI UI and E2E tests. This ensures CI fails immediately with clear error messages instead of silently skipping tests.
- Remove skipIf/shouldSkip from e2e and CLI UI tests (throw errors instead) - Move unit tests to cli/src/__tests__/unit/ - Move cli-ui.test.ts to cli/src/__tests__/e2e/ - Fix import paths in moved files
- Add flushAnalyticsThen() helper to simplify exit flow callbacks - Refactor command-registry and use-exit-handler to use new helper - Fix logger to always report errors/analytics even when file logs disabled - Update docs: fix markdown escaping and use E2E_CONTAINER_NAME env var
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.