cleanup: remove legacy backend and npm-app #389
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brandonkachen
force-pushed
the
refactor-repo-codex
branch
2 times, most recently
from
23827b2 to
6fde277
Compare
brandonkachen
force-pushed
the
main
branch
2 times, most recently
from
2c18ea5 to
08f4c5e
Compare
brandonkachen
force-pushed
the
refactor-repo-codex
branch
3 times, most recently
from
4c77af3 to
8b9ea34
Compare
brandonkachen
force-pushed
the
refactor-repo-codex
branch
2 times, most recently
from
024fe6b to
133c5ff
Compare
brandonkachen
force-pushed
the
refactor-repo-codex
branch
from
4089491 to
f64e240
Compare
- Add initializeAgentRegistry() async function called at CLI startup - Replace sync require-based agent loading with SDK loadLocalAgents() - Remove dead code: gatherAgentFiles, regex patterns, SKIPPED_DIRECTORIES - User agents now cached after SDK loads them via esbuild transpilation - Preserve file paths for user agents (for UI "Open file" links) - Update tests to work with bundled agents present (use test- prefix) - Add 24 new tests for loadLocalAgents, handleSteps, utilities, edge cases
brandonkachen
force-pushed
the
refactor-repo-codex
branch
from
f64e240 to
b102618
Compare
- Remove unused files variable in relabelUsingFullFilesForUser - Add error logging for rejected relabel promises - Extract FULL_FILE_CONTEXT_SUFFIX constant - Add warning logging when SDK agent loading fails - Improve API key error message with details and hint
- Add System type import from agent-runtime - Add StoredMessage interface for BigQuery trace messages - Add BigQueryTimestamp interface for timestamp handling - Replace all as any casts with proper type assertions
- Update common/knowledge.md to reference web, cli, sdk packages - Update ROADMAP.md with current Dec 2024 status - Update authentication.knowledge.md to remove npm-app references - Update packages/internal/src/knowledge.md package list - Update cli/knowledge.md to remove npm-app reference - Update knowledge.md referral system section
brandonkachen
force-pushed
the
refactor-repo-codex
branch
2 times, most recently
from
bdcd694 to
4cf667c
Compare
- Add webEnv export that omits CODEBUFF_API_KEY (type-level protection) - Add ESLint rule to catch direct process.env.CODEBUFF_API_KEY in web - Relabel endpoint extracts API key from Authorization header - Web imports webEnv to get TypeScript error if accessing CODEBUFF_API_KEY - Update agent-runtime README paths
brandonkachen
force-pushed
the
refactor-repo-codex
branch
from
4cf667c to
7190295
Compare
- Add ESLint rule to enforce webEnv import instead of env - Replace all env imports with webEnv in 17 web files - webEnv omits CODEBUFF_API_KEY for type-level security
- Remove CODEBUFF_API_KEY from typed serverEnvSchema entirely - Add ciOnlyEnvVars array for CI injection only - Remove webEnv/webEnvSchema (no longer needed) - Revert web files from webEnv back to env - env.CODEBUFF_API_KEY is now a TypeScript error everywhere - Keep ESLint rule for process.env.CODEBUFF_API_KEY in web
- Wrap ensureEnvDefault calls with isCI check - Local dev will fail fast on missing env vars - CI gets safe defaults for tests
- Network errors should fail the test, not be silently ignored
- Remove confusing global loadedAgents export (was mutable state) - Add proper typing with LoadedAgents and LoadedAgentDefinition types - Add _sourceFilePath to each loaded agent for debugging - Add validate option to automatically filter invalid agents - Update README with comprehensive documentation - All changes are backwards-compatible
- Add TypeScript overloads so validate: true returns { agents, validationErrors }
- Add AgentValidationError and LoadLocalAgentsResult types
- Export new types from SDK index
- Move validateAgents to static import (fix dynamic import pattern)
- Add comprehensive tests for loadLocalAgents with type safety
- Fix early return to respect validate flag
- Use codebuff/base2@latest for integration tests and e2e examples - Keep base2 for unit tests that mock the database (agent string never resolves) - Fixes "Invalid agent ID" errors in tests that hit the production API
brandonkachen
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.