Skip to content

Add differential evaluation of Scala SDK #110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
djhahe wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Add differential evaluation of Scala SDK #110

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a7e13d0
Add differential evaluation of Scala SDK
Jun 26, 2022
6f205e9
update scala sdk review
Jun 26, 2022
109a5c9
Update README.md
djhahe Jun 30, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 21 additions & 0 deletions Reviews/295 - Casper Scala SDK/Differential evaluation of Scala SDK/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
# Casper Scala SDK checklist

## Required methods

| Method | Source | | Notes |
| ------------------------- |:--------------------------------------------------------------------------------------------------------------------------------:| --- |:-----------:|
| chain_get_block | [source](https://github.com/caspercommunityio/casper-scala-sdk/blob/master/src/main/scala/com/casper/sdk/CasperSdk.scala#L43) | ✅ |Should merge into single function |
| info_get_deploy | [source](https://github.com/caspercommunityio/casper-scala-sdk/blob/master/src/main/scala/com/casper/sdk/CasperSdk.scala#L84) | ✅ | |
| account_put_deploy | [source](https://github.com/caspercommunityio/casper-scala-sdk/blob/master/src/main/scala/com/casper/sdk/CasperSdk.scala#L140) | ✅ | |
| chain_get_state_root_hash | [source](https://github.com/caspercommunityio/casper-scala-sdk/blob/master/src/main/scala/com/casper/sdk/CasperSdk.scala#L35) | ✅ | |
| state_get_account_info | N/A | ❌ | Est: 4hours |
| state_get_balance | [source](https://github.com/caspercommunityio/casper-scala-sdk/blob/master/src/main/scala/com/casper/sdk/CasperSdk.scala#L108) | ✅ | |
| state_get_dictionary_item | [source](https://github.com/caspercommunityio/casper-scala-sdk/blob/master/src/main/scala/com/casper/sdk/CasperSdk.scala#L124) | ✅ | |
| query_global_state | N/A | ❌ | Est: 4hours |


## Reviewer notes

- There are 2 missing methods: `state_get_account_info` and `query_global_state`. The estimated implementation time for each method is 4 hours.
- The implementation for chain_get_block should be merged to single function and take BlockIdentifier param. The estimated update time for the method is 1 hour.
- Other methods and types are aligned with the SDK standard.