feat: add Room.set_name() and Room.set_topic() methods - #82
Open
ishita-0301 wants to merge 2 commits into
Open
Conversation
Contributor
|
@ishita-0301 can you please fix the conflicts and the comment. Thank you. |
PenguinBoi12
reviewed
Jul 2, 2026
| except Exception as e: | ||
| raise MatrixError(f"Failed to send message: {e}") | ||
|
|
||
| async def set_name(self, name: str) -> None: |
Contributor
There was a problem hiding this comment.
A new way to handle matrix calls has been added. Basically, the whole body of the function would become:
await matrix_call(
self.client.room_put_state(
room_id=self.room_id,
event_type="m.room.name",
content={"name": name},
),
error_message="Failed to set room name"
)Same thing for set_topic
Contributor
|
Hello @ishita-0301 this PR is about to go stale and closed. Do you plan on finalizing it? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #69
Added \set_name(name)\ and \set_topic(topic)\ methods to \Room. Both use \client.room_put_state()\ to update the respective state events. Includes unit tests for success and error cases for each method.