feat: add Room.leave() method - #79
Open
ishita-0301 wants to merge 1 commit into
Open
Conversation
PenguinBoi12
self-requested a review
July 2, 2026 04:35
Contributor
|
@ishita-0301 you need to fix the conflict before I start reviewing. Thank you! |
PenguinBoi12
reviewed
Jul 2, 2026
| except Exception as e: | ||
| raise MatrixError(f"Failed to kick user: {e}") | ||
|
|
||
| async def leave(self) -> None: |
Contributor
There was a problem hiding this comment.
A new way to handle matrix calls has been added. Basically, the whole body of the function would become:
await matrix_call(
self.client.room_leave(room_id=self.room_id),
error_message="Failed to leave room"
)
Contributor
|
Hello @ishita-0301 this PR is about to go stale and closed. Do you plan on finalizing it? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #75
Added
Room.leave()async method so bots can leave a room at runtime. Follows the same error-handling pattern as existing methods likekick_userandinvite_user. Includes unit tests for success and error cases.