Add with_retry helper for retrying Matrix API calls - #116
Merged
Conversation
chrisdedman
approved these changes
Jul 23, 2026
chrisdedman
left a comment
chrisdedman
left a comment
Contributor
There was a problem hiding this comment.
LGTM. This will be very useful for our users. thanks
# Conflicts: # matrix/api.py # tests/test_api.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds a
with_retryhelper tomatrix/api.py, as discussed in #86 (review comment).Note:
matrix-nioalready retries 429s/timeouts internally (ClientConnectionError/TimeoutError/asyncio.TimeoutError), it does not cover other transport failures like a mid-request server disconnection. This is an additional mechanism for those failures that can still happen.Additionally, a new error,
MatrixApiErrorhas been added to handle possible API error and contain the retry information.Type of Change
Pre-merge Checklist
pytestmypy