Open
Conversation
dburkhart07
requested changes
Feb 6, 2026
dburkhart07
requested changes
Feb 6, 2026
dburkhart07
left a comment
dburkhart07
left a comment
There was a problem hiding this comment.
forgot to put a comment in from yesterday!
| // fields in order: second, minute, hour, day of month, month, day of week | ||
| @Cron('0 30 10 * * *') // Runs every day at 10:30 AM | ||
| async handleDailyRecurringDonations() { | ||
| this.logger.log('Running daily donation reminder cron job'); |
There was a problem hiding this comment.
I like the user of a logger. Any reason why we are doing this now over console logging like we had done previously?
dburkhart07
approved these changes
Feb 7, 2026
dburkhart07
left a comment
dburkhart07
left a comment
There was a problem hiding this comment.
Approving with a note to @Yurika-Kan and @sam-schu
Perhaps worth to make a little one point ticket to change our console logs and errors that we have (while not a ton) to be loggers instead, and start using this from here on out?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ℹ️ Issue
Closes #133
📝 Description
✔️ Verification
I verified that the cron job was running by setting the cron pattern to be every minute
@Cron('* * * * *')and running the backend to see the logs. You could alternatively do every second to verify this quicker (@Cron('* * * * * *'))🏕️ (Optional) Future Work / Notes
Did you notice anything ugly during the course of this ticket? Any bugs, design challenges, or unexpected behavior? Write it down so we can clean it up in a future ticket!