Closed
Conversation
…l-buttons Refactor modal buttons
…H/SSF-22-temporary-site-homepage
…-homepage [SSF-22] Create temporary site index on homepage
[SSF-9] Donation Management (back-end) - view donations
…orm-frontend SSF-57 Food Request Form Frontend
* Removing donation_items status and allocations status from code and db * updating frontend types for removed statuses * updating status to use enum types
* authenticator initail setup with amplify * changing setup to allow pantry application to be public route (no auth needed), adding pantry partner signup and one time donor buttons to auth form and functionality * make sign out button component instead of on landing page * resolving app.tsx conflicts with main * adding signout button to header * prettier * signout header button navigates to homepage
* added dummy data for database migration * added existing user check * added down parsing to only delete dummy data * changed dummy data to match enum and database migrations * added 10 digit phone numbers, orders and allocations * added minor changes to pantry entry * removing status cols from donation items and allocations, fixing user rolem, adding activities comments col * fix address line naming * adding additional dummy data for new pantry fields * new dummy data migration to update timestamp * minor data refactoring --------- Co-authored-by: Justin Wang <74576640+Juwang110@users.noreply.github.com> Co-authored-by: Justin Wang <Juwang110@gmail.com>
* Fixed branch issues ignoring lint (Chakra components still having weird error) * Fixed issues * Final commit * Final commit * Fixed frontend changes * Fixed frontend changes * Fixed backend * Fixed backend * Final commit * Fixed volunteer display * Final commit * Final commit * Resolved comments * Styling changes * prettier * Prettier * Fixed color theme and remove x from the modals * Final commit * prettier * Added search feature * prettier * Added modal similar to request form modal * prettier * More comments resolved * prettier * Fixed modal styligs * Resolved comments * prettier * prettier * Added proper filtering and sorting, assignee coloring, and fixed type issues * prettier * Addressed changes * Final commit * Removed useEffects for page updating * prettier * Fixed yarn.lock * Updated comments for filter states --------- Co-authored-by: Amy Wang <147568742+amywng@users.noreply.github.com>
* refactoring backend for request entity having multiple orders * adding order details endpoint and placeholder order values for outdated request management frontend * tests * prettier * new frontend design for request management page, renaming modal from order to request * frontend for request details and associated order details * prettier * minor refactoring based on comments * minor changes * prettier * fix tests * fix tests, refactor to remove readonly on request form modal * prettier * refactoring from conflict - not found exception * prettier
* refactoring backend for request entity having multiple orders * adding order details endpoint and placeholder order values for outdated request management frontend * tests * prettier * new frontend design for request management page, renaming modal from order to request * frontend for request details and associated order details * prettier * minor refactoring based on comments * minor changes * prettier * fix tests * fix tests, refactor to remove readonly on request form modal * prettier * refactoring from conflict - not found exception * prettier * revert frontend merged into this branch
swarkewalia
changed the base branch from
sk/SSF-132-verify-prettier-check
to
main
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ℹ️ Issue
Closes 132
📝 Description
Added prettier verification in our CI/CD pipeline so it runs on pushed commits and fails when there are formatting violations, and passes when they are fixed.
✔️ Verification
Tested by running yarn prettier:check and pushing a commit that I knew had formatting violations to make sure the workflow failed. Then I commited and pushed fixes by running yarn prettier:write and made sure the workflow passed since there were no violations anymore.