Skip to content

Add author entity and routes, tests#77

Open
robpatterson13 wants to merge 1 commit intomainfrom
rob-66-author-entity-and-routes
Open

Add author entity and routes, tests#77
robpatterson13 wants to merge 1 commit intomainfrom
rob-66-author-entity-and-routes

Conversation

@robpatterson13
Copy link

ℹ️ Issue

Closes #66

📝 Description

Added Author entity and service in author.entity.ts and author.service.ts respectively; added tests for service layer in author.service.spec.ts (used library.service.spec.ts as a reference in both format and things to test). Ticket said to put tests in author.service.ts but I put them in the spec file; let me know if this should be changed

✔️ Verification

Ran tests using npm run test; all passed

Copy link
Collaborator

@GauriRajesh733 GauriRajesh733 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great!! just realized this wasn't mentioned in the ticket but could you add a few tests in author.controller.spec.ts to ensure the controller calls the correct service methods as well?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Author entity & routes

2 participants