Conversation
CodSpeed Performance ReportMerging #142 will degrade performances by 50%Comparing Summary
Benchmarks breakdown
Footnotes
|
|
@rukai tests are failing but no action on your part is required, we have a msrv bump to decide on, and the other one is CI flakiness on this repo that we need to fix. |
|
Hello! As merging this would require us to raise the rust msrv of the core and the criterion compatibilty crate, we've decided not to merge this for now if the benefit is only getting rid of lazy static. Next codspeed-rust major is probably when we'll bump msrv to 1.80 since criterion did so upstream and divan already has an 1.80 msrv. We'll keep this open until then unless bumping is required to fix a security issue or if there's a more compelling argument than just getting rid of lazy static. |
|
Oh, oops I didn't realize colored had bumped it's msrv, totally understandable. Feel free to keep the pr open until you bump your msrv, or feel free to close it for now and just update your deps together once you do bump msrv. |
Mostly I just want to remove lazy_static from my dep tree, and colored 3.0.0 has removed its dependency on lazy_static.