Merged
Conversation
not-matthias
changed the title
There was a problem hiding this comment.
Pull Request Overview
This PR adds conditional measurement control for CodSpeed wall-time instrumentation based on whether benchmark warmup has completed. The intent is to exclude warmup iterations from measurements.
- Added
IsWarmupDone()getter method toBenchmarkRunnerclass - Modified CodSpeed measurement logic to only start/stop measurements after warmup completion
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| google_benchmark/src/benchmark_runner.h | Added IsWarmupDone() public getter to expose warmup completion state |
| google_benchmark/src/benchmark.cc | Modified CODSPEED_WALLTIME measurement to conditionally start/stop based on warmup state |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
CodSpeed Performance ReportMerging #32 will not alter performanceComparing Summary
|
not-matthias
force-pushed
the
cod-1589-codspeed-cpp-fix-warmup-being-sampled-by-perf
branch
from
ec8d562 to
1cac95e
Compare
GuillaumeLagrange
force-pushed
the
cod-1575-codspeed-cpp-support-custom-benchmark-name
branch
from
a34fdd1 to
cf778ec
Compare
Base automatically changed from
cod-1575-codspeed-cpp-support-custom-benchmark-name
to
main
October 30, 2025 16:28
GuillaumeLagrange
approved these changes
Nov 3, 2025
Contributor
GuillaumeLagrange
left a comment
GuillaumeLagrange
left a comment
There was a problem hiding this comment.
lgtm, needs to be rebased
not-matthias
force-pushed
the
cod-1589-codspeed-cpp-fix-warmup-being-sampled-by-perf
branch
from
1cac95e to
0b05454
Compare
not-matthias
deleted the
cod-1589-codspeed-cpp-fix-warmup-being-sampled-by-perf
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.