Repository navigation
Correct experiment configuration and model selection - #17
Merged
Merged
Conversation
This was referenced Jul 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR corrects the historical evaluation pipeline and publishes the corresponding interpretation note as one reviewable change.
QUICK_OVERVIEW.mddocs/Root cause
The previous loader did not consume the nested split keys in the checked-in config and fell back to 70/15/15 for both strategies. Several downstream summaries also selected a reported winner after observing test MAE. Training code used training rows, but repeated test-informed selection means the historical test outcomes are retrospective rather than unseen confirmatory evidence.
Reproducibility impact
configs/experiment.yamlis the corrected current pipeline.configs/experiment_legacy_v6.yamlrecords the effective historical ratios for audit.Validation
python -m pytest -q? 131 passedpython -m compileall -q srcgit diff --check origin/main...HEADScope boundary
Prospective input capture, frozen prediction, protocol, and ledger work are intentionally excluded and will be reviewed separately after this PR.