Open
Conversation
[DEV-14551]
gsimore
suggested changes
Feb 6, 2020
Contributor
gsimore
left a comment
gsimore
left a comment
There was a problem hiding this comment.
Nice improvements! Mostly looks good, I just have one suggestion
| rh = env.resource_handler.cast() | ||
| return boto3.client( | ||
| wrapper = rh.get_api_wrapper() | ||
| return wrapper.get_boto3_client( |
Contributor
There was a problem hiding this comment.
It's generally better to separate out return and a function call, doing both on the same line is too many things happening at once, which means if an exception occurs, then the traceback will point to this line and trying to debug would be harder. So I think this should change to:
client = wrapper.get_boto3_client( ...)
return client
| rh = env.resource_handler.cast() | ||
| return boto3.client( | ||
| wrapper = rh.get_api_wrapper() | ||
| return wrapper.get_boto3_client( |
Explicit is better than implicit. [DEV-14551]
gsimore
approved these changes
Jan 30, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Development Prerequisites
Summary of Proposed Changes