Use monotonic clock so postgres timeouts are unaffected by system clock changes#141
Merged
seuros merged 1 commit intoClosureTree:masterfrom Jan 15, 2026
Merged
Conversation
Member
|
That awesome, thanks. |
This was referenced Jan 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Time.nowis not a reliable way to measure elapsed time. If a system clock adjustment coincides with a lock being held, then the timeout actually used may not be the same astimeout_seconds.The monotonic clock measures elapsed time more accurately. The monotonic time is the time since the computer started up, and it is always moving forward.
This change should only affect postgres advisory locks as mysql does not use this method for its timeout behavior.