Initial counter_cache implementation#393
Open
ekampp wants to merge 2 commits intoClosureTree:masterfrom
Open
Conversation
Author
|
This sort of picks up where #109 left off. But it's re-implemented from scratch. |
|
This would be a welcome addition. Anything I can do to help make it happen? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This implements a
counter_cacheoption, which is passed to theparentrelationship. This allows closure tree structures to usetag.tags_countrather thantag.children.count. This is much faster for large data sets, where counts are prohibitively slow.TODO
I would love the maintainers comments on the three TODO items above, to make sure that this PR doesn't break anything, and brings good enough performance and documentation.
Thanks,
Emil