Skip to content

Do not fail without NormalMax/PathologicMin #121

Description

@Stikus

Hello, we are using Stranger in pipeline after https://github.com/Illumina/ExpansionHunter, and currently we have a problem.
If we want to use variant_catalog.json where there are no repeats with NormalMax/PathologicMin we are getting several warnings like:

WARNING Repeat number 1 (CSF1PO) is missing 'NormalMax'. Skipping..

and finally:

WARNING Could not find any repeat info

and program finishes with exit code 1 (due to this: https://github.com/Clinical-Genomics/stranger/blob/main/stranger/cli.py#L69-L71).

Is it possible to just warn about no repeat info and pass all input data to output (how it is done for skipped repeats)?
We can, of course, turn Stranger off for some variant_catalogs, but it will be easier for pipeline maintaining to simply not fail if there are nothing to do.

Or should we add some placeholders, like:

        "NormalMax": "-",
        "Disease": "-",
        "PathologicMin": "-"

What do you think, @dnil ?

Related to #76 (same problem origin)

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions