Skip to content

Fix(logger bug) - #258

Merged
karlnyr merged 2 commits into
masterfrom
rc5.0.2
Aug 25, 2026
Merged

Fix(logger bug)#258
karlnyr merged 2 commits into
masterfrom
rc5.0.2

Conversation

@karlnyr

@karlnyr karlnyr commented Aug 24, 2026

Copy link
Copy Markdown
Contributor

Description

Closes #257

Use a global logger, and also remove the mkdirs logic from the logger setup, as it seems unstable

Primary function of PR

  • Hot-fix
  • Patch
  • Minor functionality improvement
  • New type of analysis
  • Backward-breaking functionality improvement
  • This change requires internal documents to be updated
  • This change requires another repository to be updated

Testing

  • bash /home/proj/production/servers/resources/hasta.scilifelab.se/install-microsalt-stage.sh BRANCHNAME
  • us
  • conda activate S_microSALT
  • microSALT analyse --input /path/to/fastq/ SAMPLEINFO_FILE

Test results

These are the results of the tests, and necessary conclusions, that prove the stability of the PR.

Sign-offs

  • Approved to run at Clinical-Genomics by @karlnyr or @Clinical-Genomics/micro

Using a global logger made, and also remove the mkdirs logic from the
logger setup as it seems unstable
@karlnyr
karlnyr requested a review from a team as a code owner August 24, 2026 15:01
@karlnyr

karlnyr commented Aug 25, 2026

Copy link
Copy Markdown
Contributor Author

Rerunning a case only creates one directory!

@karlnyr
karlnyr merged commit 0df4cb0 into master Aug 25, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

microSALT creates many sample directories with job_creator.log in them

2 participants