Conversation
Bumps [pygments](https://github.com/pygments/pygments) from 2.19.2 to 2.20.0. - [Release notes](https://github.com/pygments/pygments/releases) - [Changelog](https://github.com/pygments/pygments/blob/master/CHANGES) - [Commits](pygments/pygments@2.19.2...2.20.0) --- updated-dependencies: - dependency-name: pygments dependency-version: 2.20.0 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [requests](https://github.com/psf/requests) from 2.32.5 to 2.33.0. - [Release notes](https://github.com/psf/requests/releases) - [Changelog](https://github.com/psf/requests/blob/main/HISTORY.md) - [Commits](psf/requests@v2.32.5...v2.33.0) --- updated-dependencies: - dependency-name: requests dependency-version: 2.33.0 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [mako](https://github.com/sqlalchemy/mako) from 1.3.11 to 1.3.12. - [Release notes](https://github.com/sqlalchemy/mako/releases) - [Changelog](https://github.com/sqlalchemy/mako/blob/main/CHANGES) - [Commits](https://github.com/sqlalchemy/mako/commits) --- updated-dependencies: - dependency-name: mako dependency-version: 1.3.12 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [pytest](https://github.com/pytest-dev/pytest) from 9.0.2 to 9.0.3. - [Release notes](https://github.com/pytest-dev/pytest/releases) - [Changelog](https://github.com/pytest-dev/pytest/blob/main/CHANGELOG.rst) - [Commits](pytest-dev/pytest@9.0.2...9.0.3) --- updated-dependencies: - dependency-name: pytest dependency-version: 9.0.3 dependency-type: direct:development ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [black](https://github.com/psf/black) from 26.1.0 to 26.3.1. - [Release notes](https://github.com/psf/black/releases) - [Changelog](https://github.com/psf/black/blob/main/CHANGES.md) - [Commits](psf/black@26.1.0...26.3.1) --- updated-dependencies: - dependency-name: black dependency-version: 26.3.1 dependency-type: direct:development ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [urllib3](https://github.com/urllib3/urllib3) from 2.6.3 to 2.7.0. - [Release notes](https://github.com/urllib3/urllib3/releases) - [Changelog](https://github.com/urllib3/urllib3/blob/main/CHANGES.rst) - [Commits](urllib3/urllib3@2.6.3...2.7.0) --- updated-dependencies: - dependency-name: urllib3 dependency-version: 2.7.0 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [idna](https://github.com/kjd/idna) from 3.11 to 3.15. - [Release notes](https://github.com/kjd/idna/releases) - [Changelog](https://github.com/kjd/idna/blob/master/HISTORY.md) - [Commits](kjd/idna@v3.11...v3.15) --- updated-dependencies: - dependency-name: idna dependency-version: '3.15' dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [soupsieve](https://github.com/facelessuser/soupsieve) from 2.8.3 to 2.8.4. - [Release notes](https://github.com/facelessuser/soupsieve/releases) - [Commits](facelessuser/soupsieve@2.8.3...2.8.4) --- updated-dependencies: - dependency-name: soupsieve dependency-version: 2.8.4 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR makes generated MicroSALT HTML reports fully self-contained by embedding the MicroSALT and Swedac logos as inline data:image/jpeg;base64,... URIs instead of loading them from remote GitHub URLs.
Changes:
- Added
microSALT/server/utils.pywith logo resource paths and aread_jpg()helper to build JPEG data URIs. - Injected
read_jpgand the logo paths into the Jinja2 environment as globals frommicroSALT/server/views.py. - Updated report templates to use
read_jpg(...)rather than hardcoded remoteraw=trueimage URLs.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| microSALT/server/views.py | Adds Jinja globals for logo embedding and minor formatting cleanups. |
| microSALT/server/utils.py | Introduces helper + constants for resolving and base64-encoding logo assets. |
| microSALT/server/templates/typing_page.html | Switches logo <img src> to embedded data URIs (including conditional Swedac logo). |
| microSALT/server/templates/STtracker_page.html | Switches MicroSALT logo <img src> to embedded data URI. |
| microSALT/server/templates/alignment_page.html | Switches MicroSALT logo <img src> to embedded data URI. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
…e-2.8.4 Bump soupsieve from 2.8.3 to 2.8.4
…2.7.0 Bump urllib3 from 2.6.3 to 2.7.0
….3.1 Bump black from 26.1.0 to 26.3.1
….0.3 Bump pytest from 9.0.2 to 9.0.3
Bump mako from 1.3.11 to 1.3.12
…-2.33.0 Bump requests from 2.32.5 to 2.33.0
…-2.20.0 Bump pygments from 2.19.2 to 2.20.0
Bump idna from 3.11 to 3.15
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Contributor
Author
Contributor
Author
jemten
reviewed
Aug 20, 2026
jemten
left a comment
There was a problem hiding this comment.
A couple of questions but otherwise it looks good.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.





Description
Previously, the MicroSALT and Swedac logos in generated reports were loaded via remote GitHub URLs (
raw=truelinks). This means reports required an active internet connection to display the logos, and would silently break if GitHub was unreachable or if the artwork paths changed.This PR embeds both logos as base64-encoded inline data URIs at render time, reading the image files directly from the installed package. Reports are now fully self-contained.
Additionally, this PR includes a few dependabot alerts.
Primary function of PR
Changes:
microSALT/server/utils.pywithread_jpg()(base64 encoder) and pre-resolved pathsMICROSALT_LOGO_PATH/SWEDAC_LOGO_PATHpointing into the installed package'sartwork/directory.views.pyinjects these as Jinja2 globals so all templates can use them.typing_page.html,alignment_page.html, andSTtracker_page.htmlupdated to callread_jpg(file_path=...)instead of hardcoded remotesrcURLs.Testing
bash /home/proj/production/servers/resources/hasta.scilifelab.se/install-microsalt-stage.sh BRANCHNAMEusconda activate S_microSALTmicroSALT analyse --input /path/to/fastq/ SAMPLEINFO_FILEQuick local verification (no deployment needed):
Test results
Verified locally: rendered
typing_page.htmlcontainsdata:image/jpeg;base64,...inline data URIs for both logos. Opening the output HTML in a browser shows logos without any network requests.Sign-offs