Respect configured cron timezone#127
Merged
Merged
Conversation
Resolve conflicts with ClickHouse#138 (_crontab_to_trigger): thread the configured timezone through the helper at all call sites instead of reverting to host-tz CronTrigger.from_crontab. Also set config.timezone in the wakeup-sweep test fixture so CronService.__init__ accepts it.
Re-sync onto latest main (ClickHouse#126 manual cron rotation, ClickHouse#133 sidebar). service.py auto-merged cleanly: ClickHouse#126's force-rotation logic and ClickHouse#127's configured-timezone fix coexist in _maybe_rotate_context. Resolved the additive test conflict by keeping both new rotation tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Make cron scheduling honor the configured Nerve timezone instead of the server/container timezone.
Root cause
NerveConfig.timezonewas defined and documented, butCronServicecreated APScheduler and cron triggers without passing it through. APScheduler therefore defaulted to the host timezone.context_rotate_athad the same problem because it derived "local" time from the OS timezone.Changes
ZoneInfo(config.timezone)for cron service scheduling.context_rotate_at.Validation
python -m pytest tests/test_cron.py -q