Repository navigation
Fetch remote previews through base PR refs - #363
Merged
Merged
Conversation
|
🕵
|
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 59b2682. Configure here.
| commit = (extracted.split("-").pop() ?? "unknown").toLowerCase(); | ||
| if (expectedCommit && commit !== expectedCommit) { | ||
| throw new Error(`fetch-remotes: archive for ${r.name} resolved to ${commit}, expected ${expectedCommit}`); | ||
| } |
There was a problem hiding this comment.
Archive SHA check always fails
Low Severity
The new archive fallback treats the tarball root directory suffix as the fetched commit and compares it to expectedCommit, a 40-character SHA. GitHub's tarball API names that directory with a short SHA, so the check rejects a valid archive whenever a SHA-only preview falls back after sparse clone fails.
Reviewed by Cursor Bugbot for commit 59b2682. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
refs/pull/<number>/headref.Validation
refs/pull/101/headfetch fromClickHouse/dbt-clickhouseresolves to its advertised SHA.