1.23 beta5 - #898
Merged
Merged
Conversation
## Problem The `publish: datatype parser` workflow ([failing run](https://github.com/ClickHouse/clickhouse-js/actions/runs/28300601707/job/83848134306)) fails at the `npm ci` step: ``` sh: 1: cd: can't cd to node_modules/parquet-wasm npm error command failed npm error command sh -c cd node_modules/parquet-wasm && npm pkg delete type ``` The job runs `npm ci` with `working-directory: packages/datatype-parser`. Because that package has no lockfile of its own, npm resolves to the **root workspace** install, which fires the root `postinstall`. In that scoped install `parquet-wasm` (a test-only root devDependency, unrelated to the datatype-parser package) isn't present, so `cd node_modules/parquet-wasm` exits non-zero and aborts the whole install — the publish job never reaches its build step. ## Fix Guard the root `postinstall` so it skips cleanly when `parquet-wasm` is absent instead of hard-failing: ```json "postinstall": "cd node_modules/parquet-wasm 2>/dev/null && npm pkg delete type || true", ``` This is harmless for the normal full dev install (dir present → runs as before) and unblocks any `npm ci` that doesn't pull in `parquet-wasm`, including this publish workflow. ## Follow-up The publish workflow dispatches from the protected `release` branch, so after this merges to `main`, `release` needs to be updated to the new snapshot before re-dispatching the publish. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool. What Enabling Code Scanning Means:
For more information about GitHub Code Scanning, check out the documentation. |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adjusts the root workspace postinstall to avoid failing when parquet-wasm isn’t present, unblocking the publish: datatype parser workflow where npm ci is executed from packages/datatype-parser and does not install root-only devDependencies.
Changes:
- Make the root
postinstalltolerant of missingnode_modules/parquet-wasmduring scoped installs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.