Address PR #876 review comments - #878
Merged
Merged
Conversation
- CHANGELOG: move the @clickhouse/client-common deprecation Migration Notes from 1.22.0 to the unreleased 1.23.0 heading. - RELEASING: clarify that npm 11.x is newer than the npm bundled with Node.js 20.x/22.x and how to obtain it. - e2e smoke tests: use assert.strictEqual instead of loose assert.equal. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses prior review feedback from #876 by tightening assertions in the e2e smoke checks and clarifying release-tooling requirements, while also moving the @clickhouse/client-common deprecation migration note to the correct unreleased version heading.
Changes:
- Moved the
@clickhouse/client-commondeprecation note from1.22.0to1.23.0inCHANGELOG.md. - Clarified the npm
>= 11.xrequirement inRELEASING.md, including upgrade options. - Updated e2e smoke checks to use
assert.strictEqualinstead ofassert.equal.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tests/e2e/smoke/check.mjs | Switches ESM smoke assertions to strictEqual to avoid loose equality. |
| tests/e2e/smoke/check.cjs | Switches CJS smoke assertions to strictEqual to avoid loose equality. |
| RELEASING.md | Documents npm >= 11 requirement with concrete upgrade guidance. |
| CHANGELOG.md | Places the deprecation migration note under the correct unreleased 1.23.0 heading. |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Addresses the Copilot review comments on #876.
@clickhouse/client-commondeprecation Migration Notes from the1.22.0heading to the unreleased1.23.0heading, since that observable change (node/web no longer depend on client-common) ships in this release.11.xrequirement: it's newer than the npm bundled with Node.js20.x/22.x(10.x); either upgrade npm in place or use Node.js24.x(which ships npm11.x).assert.strictEqualinstead of looseassert.equal.🤖 Generated with Claude Code