ci fix - #874
Merged
Merged
ci fix#874
Conversation
Follow-up to #870 / #871. ## Why Re-running the unit suite inside the release workflow turned out to require more setup than it's worth, and the `release` branch is itself protected — so the unit gate adds little there. Instead, the release should validate the **actual artifact** it ships. ## Changes (`publish-skill-rowbinary-parser.yml`) The `publish` job now: 1. **Build** the package. 2. **Pack** the tarball (`npm pack`; `prepack` copies the LICENSE + rebuilds dist). 3. **Pre-publish smoke test** — install that exact tarball into a throwaway project and import the main barrel (`readRows`) + a subpath export (`/integers` → `readUInt8`). 4. **Publish** the *same* tarball with `--access public --provenance`, so the artifact that ships is the one that passed the smoke test. 5. Push the `rowbinary-v<version>` git tag. Removed the `typecheck` / `npm test` steps. The post-publish `e2e` job (wait for the version on npm, then install + import across Node 20/22/24) is unchanged. ## Verification Locally exercised build → pack → install tarball + import smoke test → `npm publish <tarball> --dry-run` (confirms tag `latest`, public access). Provenance is the only step not reproducible locally (needs CI OIDC); publishing a tarball with `--provenance` is supported. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool. What Enabling Code Scanning Means:
For more information about GitHub Code Scanning, check out the documentation. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adjusts the standalone @clickhouse/rowbinary publish workflow to validate the exact npm artifact that will be released, instead of re-running the unit/typecheck gates in the release workflow.
Changes:
- Remove
typecheckandnpm testfrom the publish job. - Build +
npm packthe package, then smoke-test by installing the packed tarball into a throwaway project and importing both the main barrel and a subpath export. - Publish the same tarball (with
--provenance) and keep the existing post-publish e2e install/import validation across Node 20/22/24.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #870 / #871.
Why
Re-running the unit suite inside the release workflow turned out to require more setup than it's worth, and the
releasebranch is itself protected — so the unit gate adds little there. Instead, the release should validate the actual artifact it ships.Changes (
publish-skill-rowbinary-parser.yml)The
publishjob now:npm pack;prepackcopies the LICENSE + rebuilds dist).readRows) + a subpath export (/integers→readUInt8).--access public --provenance, so the artifact that ships is the one that passed the smoke test.rowbinary-v<version>git tag.Removed the
typecheck/npm teststeps. The post-publishe2ejob (wait for the version on npm, then install + import across Node 20/22/24) is unchanged.Verification
Locally exercised build → pack → install tarball + import smoke test →
npm publish <tarball> --dry-run(confirms taglatest, public access). Provenance is the only step not reproducible locally (needs CI OIDC); publishing a tarball with--provenanceis supported.🤖 Generated with Claude Code
Summary
A short description of the changes with a link to an open issue.
Checklist
Delete items not relevant to your PR: