Skip to content

ci fix - #874

Merged
peter-leonov-ch merged 1 commit into
releasefrom
main
Jun 22, 2026
Merged

ci fix#874
peter-leonov-ch merged 1 commit into
releasefrom
main

Conversation

@peter-leonov-ch

Copy link
Copy Markdown
Collaborator

Follow-up to #870 / #871.

Why

Re-running the unit suite inside the release workflow turned out to require more setup than it's worth, and the release branch is itself protected — so the unit gate adds little there. Instead, the release should validate the actual artifact it ships.

Changes (publish-skill-rowbinary-parser.yml)

The publish job now:

  1. Build the package.
  2. Pack the tarball (npm pack; prepack copies the LICENSE + rebuilds dist).
  3. Pre-publish smoke test — install that exact tarball into a throwaway project and import the main barrel (readRows) + a subpath export (/integersreadUInt8).
  4. Publish the same tarball with --access public --provenance, so the artifact that ships is the one that passed the smoke test.
  5. Push the rowbinary-v<version> git tag.

Removed the typecheck / npm test steps. The post-publish e2e job (wait for the version on npm, then install + import across Node 20/22/24) is unchanged.

Verification

Locally exercised build → pack → install tarball + import smoke test → npm publish <tarball> --dry-run (confirms tag latest, public access). Provenance is the only step not reproducible locally (needs CI OIDC); publishing a tarball with --provenance is supported.

🤖 Generated with Claude Code

Summary

A short description of the changes with a link to an open issue.

Checklist

Delete items not relevant to your PR:

  • Unit and integration tests covering the common scenarios were added
  • A human-readable description of the changes was provided to include in CHANGELOG
  • For significant changes, documentation in https://github.com/ClickHouse/clickhouse-docs was updated with further explanations or tutorials

Follow-up to #870 / #871.

## Why

Re-running the unit suite inside the release workflow turned out to
require more setup than it's worth, and the `release` branch is itself
protected — so the unit gate adds little there. Instead, the release
should validate the **actual artifact** it ships.

## Changes (`publish-skill-rowbinary-parser.yml`)

The `publish` job now:
1. **Build** the package.
2. **Pack** the tarball (`npm pack`; `prepack` copies the LICENSE +
rebuilds dist).
3. **Pre-publish smoke test** — install that exact tarball into a
throwaway project and import the main barrel (`readRows`) + a subpath
export (`/integers` → `readUInt8`).
4. **Publish** the *same* tarball with `--access public --provenance`,
so the artifact that ships is the one that passed the smoke test.
5. Push the `rowbinary-v<version>` git tag.

Removed the `typecheck` / `npm test` steps. The post-publish `e2e` job
(wait for the version on npm, then install + import across Node
20/22/24) is unchanged.

## Verification

Locally exercised build → pack → install tarball + import smoke test →
`npm publish <tarball> --dry-run` (confirms tag `latest`, public
access). Provenance is the only step not reproducible locally (needs CI
OIDC); publishing a tarball with `--provenance` is supported.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Copilot AI review requested due to automatic review settings June 22, 2026 20:12
@github-advanced-security

Copy link
Copy Markdown

You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool.

What Enabling Code Scanning Means:

  • The 'Security' tab will display more code scanning analysis results (e.g., for the default branch).
  • Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results.
  • You will be able to see the analysis results for the pull request's branch on this overview once the scans have completed and the checks have passed.

For more information about GitHub Code Scanning, check out the documentation.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adjusts the standalone @clickhouse/rowbinary publish workflow to validate the exact npm artifact that will be released, instead of re-running the unit/typecheck gates in the release workflow.

Changes:

  • Remove typecheck and npm test from the publish job.
  • Build + npm pack the package, then smoke-test by installing the packed tarball into a throwaway project and importing both the main barrel and a subpath export.
  • Publish the same tarball (with --provenance) and keep the existing post-publish e2e install/import validation across Node 20/22/24.

@peter-leonov-ch
peter-leonov-ch merged commit 603fac7 into release Jun 22, 2026
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants