RowBinary 0.1.1 release - #872
Merged
Merged
Conversation
… skill-only changes (#864) ## Summary Adding a high-performance `RowBinary` reader library supporting 95% of types. The library is also itself a skill for LLMs to generate even faster (2-3x) bespoke optimized concrete response type parsers. Additionally, CI workflow triggers were updated so skill-only changes under `skills/**` do not run unrelated monorepo library test workflows (Node/Web/Bun/OSS dependents/examples), while skills validation remains covered by the Skills E2E workflow. ## Checklist Delete items not relevant to your PR: - [x] Unit and integration tests covering the common scenarios were added - [x] A human-readable description of the changes was provided to include in CHANGELOG - [ ] For significant changes, documentation in https://github.com/ClickHouse/clickhouse-docs was updated with further explanations or tutorials --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Bumps version from `1.22.0` to `1.23.0` (minor bump). Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
## Summary A short description of the changes with a link to an open issue. ## Checklist Delete items not relevant to your PR: - [ ] Unit and integration tests covering the common scenarios were added - [ ] A human-readable description of the changes was provided to include in CHANGELOG - [ ] For significant changes, documentation in https://github.com/ClickHouse/clickhouse-docs was updated with further explanations or tutorials --------- Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
## What Makes the standalone `@clickhouse/rowbinary` package (the RowBinary parser skill under `skills/clickhouse-js-node-rowbinary-parser`) ready to publish, and gives it a proper independent release workflow. ## Changes - **`package.json`**: add `publishConfig.access: "public"` so the scoped package publishes publicly on first release, and `engines.node: ">=20"` to match the rest of the repo. - **`.github/workflows/publish-skill-rowbinary-parser.yml`**: bring the existing manual publish workflow up to `publish.yml`'s release rigor — - gate on `npm test` (in addition to typecheck/build), - push a namespaced `rowbinary-v<version>` git tag after publish (won't collide with the main packages' bare `1.x.x` tags), - add an `e2e` job that waits for the published version on npm and smoke-tests a downstream install + import of the main barrel and a subpath export across Node 20/22/24. - **`README.md` / `CHANGELOG.md`**: point the repo's package list at `@clickhouse/rowbinary` and add the 1.23.0 changelog entry. ## Notes - This package is **not** part of the npm workspace lockstep release; it carries its own version and ships on its own manual cadence (`workflow_dispatch`). - Verified locally: clean build, typecheck, 473 unit tests pass, and a packed-tarball install resolves both the main entry and subpath exports. 🤖 Generated with [Claude Code](https://claude.com/claude-code) --------- Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Follow-up to #870. ## Why Dispatching the rowbinary publish workflow from `main` is rejected by GitHub: > Branch "main" is not allowed to deploy to npm-publish due to environment protection rules. The `npm-publish` environment is branch-protected to the `release` branch — the repo's human-in-the-loop release gate (same model as `publish.yml`, whose jobs are guarded by `if: github.ref == 'refs/heads/release'`). The standalone rowbinary publish workflow lacked that guard, and the main test suites weren't validating the `release` branch on push. ## Changes - **`publish-skill-rowbinary-parser.yml`**: guard the `publish` job with `if: github.ref == 'refs/heads/release'` so it skips cleanly on other refs instead of failing the environment protection check, and document that it must be dispatched from `release`. - **`tests-node` / `tests-web` / `tests-bun` / `tests-oss-dependents`**: add `release` to the push-trigger branches so the release branch is validated before/as it publishes (`examples.yml` already had it). ## Release flow (unchanged, now consistent) 1. Land changes on `main`. 2. Promote to `release` → test suites run on the release branch. 3. Dispatch `publish: rowbinary parser` from `release` → publishes with OIDC/provenance and tags `rowbinary-v<version>`. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool. What Enabling Code Scanning Means:
For more information about GitHub Code Scanning, check out the documentation. |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Contributor
There was a problem hiding this comment.
Pull request overview
Releases ClickHouse JS clients 1.23.0 and introduces a new Node.js-focused RowBinary parsing library/agent skill (@clickhouse/rowbinary@0.1.1), along with CI and a small demo app showcasing RowBinary decoding.
Changes:
- Bumped
@clickhouse/client,@clickhouse/client-web,@clickhouse/client-common, and test-runner versions to1.23.0and updatedCHANGELOG.md. - Added the
@clickhouse/rowbinarypackage +clickhouse-js-node-rowbinary-parserskill (readers, examples, extensive tests/benches, and a dedicated CI workflow). - Added a server-only Next.js “RowBinary logs” demo and tightened GitHub Actions workflow path filters.
Reviewed changes
Copilot reviewed 170 out of 176 changed files in this pull request and generated 12 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/clickhouse-test-runner/package.json | Bump test-runner version to 1.23.0 |
| skills/clickhouse-js-node-rowbinary-parser/package.json | New @clickhouse/rowbinary package metadata/scripts |
| skills/clickhouse-js-node-rowbinary-parser/vitest.config.ts | Vitest config for the skill package |
| skills/clickhouse-js-node-rowbinary-parser/tsconfig.json | Skill TypeScript config (typecheck) |
| skills/clickhouse-js-node-rowbinary-parser/tsconfig.build.json | Skill build TS config (emit dist/) |
| skills/clickhouse-js-node-rowbinary-parser/.gitignore | Ignore dist/node_modules + copied LICENSE |
| skills/clickhouse-js-node-rowbinary-parser/README.md | Skill/library documentation |
| skills/clickhouse-js-node-rowbinary-parser/SKILL.md | Agent skill instructions/metadata |
| skills/clickhouse-js-node-rowbinary-parser/EXAMPLES.md | Guide to example readers/benches |
| skills/clickhouse-js-node-rowbinary-parser/eval_result.md | Skill evaluation results artifact |
| skills/clickhouse-js-node-rowbinary-parser/eval_result_haiku.md | Skill evaluation results artifact |
| skills/clickhouse-js-node-rowbinary-parser/eval_result_sonnet.md | Skill evaluation results artifact |
| skills/clickhouse-js-node-rowbinary-parser/eval_result_composer.md | Skill evaluation results artifact |
| skills/clickhouse-js-node-rowbinary-parser/case-studies/iot-rowbinary-vs-json.md | Case study doc |
| skills/clickhouse-js-node-rowbinary-parser/case-studies/ledger-rowbinary-vs-json.md | Case study doc |
| skills/clickhouse-js-node-rowbinary-parser/case-studies/logs-json-wins.md | Case study doc |
| skills/clickhouse-js-node-rowbinary-parser/case-studies/wasm-vs-js.md | Case study doc |
| skills/clickhouse-js-node-rowbinary-parser/src/core.ts | Cursor state + advance() + NeedMoreData |
| skills/clickhouse-js-node-rowbinary-parser/src/varint.ts | LEB128 varint reader |
| skills/clickhouse-js-node-rowbinary-parser/src/integers.ts | Fixed-width integer readers |
| skills/clickhouse-js-node-rowbinary-parser/src/floats.ts | Float32/64 + BFloat16 readers |
| skills/clickhouse-js-node-rowbinary-parser/src/bool.ts | Bool reader |
| skills/clickhouse-js-node-rowbinary-parser/src/enums.ts | Enum8/Enum16 underlying-value readers |
| skills/clickhouse-js-node-rowbinary-parser/src/strings.ts | String/FixedString readers |
| skills/clickhouse-js-node-rowbinary-parser/src/uuid.ts | UUID readers + formatters |
| skills/clickhouse-js-node-rowbinary-parser/src/ip.ts | IPv4/IPv6 readers + formatters |
| skills/clickhouse-js-node-rowbinary-parser/src/datetime.ts | Date/DateTime/DateTime64 readers |
| skills/clickhouse-js-node-rowbinary-parser/src/time.ts | Time/Time64 readers + formatters |
| skills/clickhouse-js-node-rowbinary-parser/src/interval.ts | Interval reader + unit table |
| skills/clickhouse-js-node-rowbinary-parser/src/decimals.ts | Decimal readers + formatter |
| skills/clickhouse-js-node-rowbinary-parser/src/composite.ts | Nullable/Array/Map/Tuple/Variant combinators |
| skills/clickhouse-js-node-rowbinary-parser/src/geo.ts | Geo-type readers incl. Geometry discriminant |
| skills/clickhouse-js-node-rowbinary-parser/src/json.ts | ClickHouse JSON (path/value pairs) reader |
| skills/clickhouse-js-node-rowbinary-parser/src/dynamic.ts | Dynamic type-tag dispatch + nested type parsing |
| skills/clickhouse-js-node-rowbinary-parser/src/rows.ts | readRows() batch driver with NeedMoreData handling |
| skills/clickhouse-js-node-rowbinary-parser/src/stream.ts | streamRowBatches() + coalesceChunks() |
| skills/clickhouse-js-node-rowbinary-parser/src/columnar.ts | Example fixed-stride columnar streaming decoder |
| skills/clickhouse-js-node-rowbinary-parser/src/lowCardinality.ts | LowCardinality identity combinator |
| skills/clickhouse-js-node-rowbinary-parser/src/simpleAggregateFunction.ts | SimpleAggregateFunction identity combinator |
| skills/clickhouse-js-node-rowbinary-parser/src/nested.ts | Nested alias (Array(TupleNamed(...))) |
| skills/clickhouse-js-node-rowbinary-parser/src/nothing.ts | Nothing guard reader |
| skills/clickhouse-js-node-rowbinary-parser/src/aggregateFunction.ts | AggregateFunction guard reader |
| skills/clickhouse-js-node-rowbinary-parser/src/reader.ts | Barrel export for the library |
| skills/clickhouse-js-node-rowbinary-parser/src/examples/events.ts | Example scalar row reader (+ fast variant) |
| skills/clickhouse-js-node-rowbinary-parser/src/examples/profiles.ts | Example Array/Nullable row reader (+ fast variant) |
| skills/clickhouse-js-node-rowbinary-parser/src/examples/carts.ts | Example nested generics row reader (+ fast variant) |
| skills/clickhouse-js-node-rowbinary-parser/src/examples/orders.ts | Example UUID/Decimal/Enum row reader (+ fast variant) |
| skills/clickhouse-js-node-rowbinary-parser/src/examples/telemetry.ts | Example Map/Array/Nullable/Tuple row reader (+ fast variant) |
| skills/clickhouse-js-node-rowbinary-parser/src/examples/observability.ts | Example gotcha-heavy row reader (+ fast variant) |
| skills/clickhouse-js-node-rowbinary-parser/src/examples/logs.ts | Example “JSON may win” string-heavy schema |
| skills/clickhouse-js-node-rowbinary-parser/src/examples/iot.ts | Fixed-width IoT row + columnar decode example |
| skills/clickhouse-js-node-rowbinary-parser/src/examples/ledger.ts | Wide-numeric ledger example |
| skills/clickhouse-js-node-rowbinary-parser/tests/clickhouse.ts | Live ClickHouse query helper for tests |
| skills/clickhouse-js-node-rowbinary-parser/tests/UVarint.test.ts | Varint correctness + NeedMoreData tests |
| skills/clickhouse-js-node-rowbinary-parser/tests/advance.test.ts | advance() / starvation semantics tests |
| skills/clickhouse-js-node-rowbinary-parser/tests/rows.test.ts | Multi-row decoding + commit-point behavior |
| skills/clickhouse-js-node-rowbinary-parser/tests/streamRowBatches.test.ts | Chunked streaming decode tests |
| skills/clickhouse-js-node-rowbinary-parser/tests/coalesceChunks.test.ts | Chunk coalescing behavior tests |
| skills/clickhouse-js-node-rowbinary-parser/tests/framing.test.ts | Row framing tests for mixed schemas |
| skills/clickhouse-js-node-rowbinary-parser/tests/framing-nested.test.ts | Framing tests for nested composites |
| skills/clickhouse-js-node-rowbinary-parser/tests/framing-interleaved.test.ts | Framing tests for interleaved layouts |
| skills/clickhouse-js-node-rowbinary-parser/tests/columnar.test.ts | Columnar streaming example tests |
| skills/clickhouse-js-node-rowbinary-parser/tests/combinations.generated.test.ts | Generated combinator-coverage test suite |
| skills/clickhouse-js-node-rowbinary-parser/tests/Dynamic.test.ts | Dynamic decoding coverage tests |
| skills/clickhouse-js-node-rowbinary-parser/tests/JSON.test.ts | JSON type decoding tests |
| skills/clickhouse-js-node-rowbinary-parser/tests/UUID.test.ts | UUID decode/format tests |
| skills/clickhouse-js-node-rowbinary-parser/tests/UUIDBigInt.test.ts | UUID->BigInt decode tests |
| skills/clickhouse-js-node-rowbinary-parser/tests/UUIDHiLo.test.ts | UUID hi/lo decode tests |
| skills/clickhouse-js-node-rowbinary-parser/tests/readUUID.bench.ts | UUID formatter benchmark |
| skills/clickhouse-js-node-rowbinary-parser/tests/events.example.test.ts | End-to-end example test (events) |
| skills/clickhouse-js-node-rowbinary-parser/tests/events.bench.ts | Example benchmark (events) |
| skills/clickhouse-js-node-rowbinary-parser/tests/profiles.example.test.ts | End-to-end example test (profiles) |
| skills/clickhouse-js-node-rowbinary-parser/tests/profiles.bench.ts | Example benchmark (profiles) |
| skills/clickhouse-js-node-rowbinary-parser/tests/carts.example.test.ts | End-to-end example test (carts) |
| skills/clickhouse-js-node-rowbinary-parser/tests/carts.bench.ts | Example benchmark (carts) |
| skills/clickhouse-js-node-rowbinary-parser/tests/orders.example.test.ts | End-to-end example test (orders) |
| skills/clickhouse-js-node-rowbinary-parser/tests/orders.bench.ts | Example benchmark (orders) |
| skills/clickhouse-js-node-rowbinary-parser/tests/telemetry.example.test.ts | End-to-end example test (telemetry) |
| skills/clickhouse-js-node-rowbinary-parser/tests/telemetry.bench.ts | Example benchmark (telemetry) |
| skills/clickhouse-js-node-rowbinary-parser/tests/observability.example.test.ts | End-to-end example test (observability) |
| skills/clickhouse-js-node-rowbinary-parser/tests/observability.bench.ts | Example benchmark (observability) |
| skills/clickhouse-js-node-rowbinary-parser/tests/iot.bench.ts | IoT benchmark suite |
| skills/clickhouse-js-node-rowbinary-parser/tests/iot.columnar.bench.ts | IoT AoS vs SoA benchmark |
| skills/clickhouse-js-node-rowbinary-parser/tests/iot.wasm-headroom.bench.ts | IoT WASM headroom benchmark |
| skills/clickhouse-js-node-rowbinary-parser/tests/ledger.bench.ts | Ledger benchmark suite |
| skills/clickhouse-js-node-rowbinary-parser/tests/logs.bench.ts | Logs benchmark suite |
| skills/clickhouse-js-node-rowbinary-parser/tests/streamingRow.bench.ts | Throw+restart vs generator benchmark |
| skills/clickhouse-js-node-rowbinary-parser/tests/wasm-int128.experiment.mjs | WASM Int128 experiment script |
| skills/clickhouse-js-node-rowbinary-parser/tests/aggregateFunction.test.ts | AggregateFunction guard + escape hatch tests |
| skills/clickhouse-js-node-rowbinary-parser/tests/simpleAggregateFunction.test.ts | SimpleAggregateFunction transparency test |
| skills/clickhouse-js-node-rowbinary-parser/tests/lowCardinality.test.ts | LowCardinality transparency test |
| skills/clickhouse-js-node-rowbinary-parser/tests/nothing.test.ts | Nothing zero-width behavior tests |
| skills/clickhouse-js-node-rowbinary-parser/tests/nested.test.ts | Nested-as-array-of-tuple tests |
| skills/clickhouse-js-node-rowbinary-parser/tests/qbit.test.ts | QBit transparency tests |
| skills/clickhouse-js-node-rowbinary-parser/tests/Variant.test.ts | Variant discriminant ordering tests |
| skills/clickhouse-js-node-rowbinary-parser/tests/Nullable.test.ts | Nullable framing/edge tests |
| skills/clickhouse-js-node-rowbinary-parser/tests/Array.test.ts | Array framing/edge tests |
| skills/clickhouse-js-node-rowbinary-parser/tests/Map.test.ts | Map framing/edge tests |
| skills/clickhouse-js-node-rowbinary-parser/tests/Tuple.test.ts | Tuple decoding tests |
| skills/clickhouse-js-node-rowbinary-parser/tests/TupleNamed.test.ts | Named tuple decoding tests |
| skills/clickhouse-js-node-rowbinary-parser/tests/String.test.ts | String decoding tests |
| skills/clickhouse-js-node-rowbinary-parser/tests/FixedString.test.ts | FixedString decoding tests |
| skills/clickhouse-js-node-rowbinary-parser/tests/FixedStringBytes.test.ts | FixedString raw-bytes tests |
| skills/clickhouse-js-node-rowbinary-parser/tests/Bool.test.ts | Bool decoding tests |
| skills/clickhouse-js-node-rowbinary-parser/tests/Enum8.test.ts | Enum8 decoding tests |
| skills/clickhouse-js-node-rowbinary-parser/tests/Enum16.test.ts | Enum16 decoding tests |
| skills/clickhouse-js-node-rowbinary-parser/tests/Float32.test.ts | Float32 decoding tests |
| skills/clickhouse-js-node-rowbinary-parser/tests/Float64.test.ts | Float64 decoding tests |
| skills/clickhouse-js-node-rowbinary-parser/tests/BFloat16.test.ts | BFloat16 decoding tests |
| skills/clickhouse-js-node-rowbinary-parser/tests/Int8.test.ts | Int8 decoding tests |
| skills/clickhouse-js-node-rowbinary-parser/tests/Int16.test.ts | Int16 decoding tests |
| skills/clickhouse-js-node-rowbinary-parser/tests/Int32.test.ts | Int32 decoding tests |
| skills/clickhouse-js-node-rowbinary-parser/tests/Int64.test.ts | Int64 decoding tests |
| skills/clickhouse-js-node-rowbinary-parser/tests/Int128.test.ts | Int128 decoding tests |
| skills/clickhouse-js-node-rowbinary-parser/tests/Int256.test.ts | Int256 decoding tests |
| skills/clickhouse-js-node-rowbinary-parser/tests/UInt8.test.ts | UInt8 decoding tests |
| skills/clickhouse-js-node-rowbinary-parser/tests/UInt16.test.ts | UInt16 decoding tests |
| skills/clickhouse-js-node-rowbinary-parser/tests/UInt32.test.ts | UInt32 decoding tests |
| skills/clickhouse-js-node-rowbinary-parser/tests/UInt64.test.ts | UInt64 decoding tests |
| skills/clickhouse-js-node-rowbinary-parser/tests/UInt128.test.ts | UInt128 decoding tests |
| skills/clickhouse-js-node-rowbinary-parser/tests/UInt256.test.ts | UInt256 decoding tests |
| skills/clickhouse-js-node-rowbinary-parser/tests/Decimal32.test.ts | Decimal32 decoding tests |
| skills/clickhouse-js-node-rowbinary-parser/tests/Decimal64.test.ts | Decimal64 decoding tests |
| skills/clickhouse-js-node-rowbinary-parser/tests/Decimal128.test.ts | Decimal128 decoding tests |
| skills/clickhouse-js-node-rowbinary-parser/tests/Decimal256.test.ts | Decimal256 decoding tests |
| skills/clickhouse-js-node-rowbinary-parser/tests/Date.test.ts | Date decoding tests |
| skills/clickhouse-js-node-rowbinary-parser/tests/Date32.test.ts | Date32 decoding tests |
| skills/clickhouse-js-node-rowbinary-parser/tests/DateTime.test.ts | DateTime decoding tests |
| skills/clickhouse-js-node-rowbinary-parser/tests/DateTime64.test.ts | DateTime64 generic decoding tests |
| skills/clickhouse-js-node-rowbinary-parser/tests/DateTime64P3.test.ts | DateTime64(3) decoding tests |
| skills/clickhouse-js-node-rowbinary-parser/tests/DateTime64P6.test.ts | DateTime64(6) decoding tests |
| skills/clickhouse-js-node-rowbinary-parser/tests/DateTime64P9.test.ts | DateTime64(9) decoding tests |
| skills/clickhouse-js-node-rowbinary-parser/tests/Time.test.ts | Time decoding tests |
| skills/clickhouse-js-node-rowbinary-parser/tests/Time64.test.ts | Time64 decoding tests |
| skills/clickhouse-js-node-rowbinary-parser/tests/Interval.test.ts | Interval decoding tests |
| skills/clickhouse-js-node-rowbinary-parser/tests/IPv4.test.ts | IPv4 decoding/format tests |
| skills/clickhouse-js-node-rowbinary-parser/tests/IPv6.test.ts | IPv6 decoding/format tests |
| skills/clickhouse-js-node-rowbinary-parser/tests/Point.test.ts | Geo Point decoding tests |
| skills/clickhouse-js-node-rowbinary-parser/tests/Ring.test.ts | Geo Ring decoding tests |
| skills/clickhouse-js-node-rowbinary-parser/tests/LineString.test.ts | Geo LineString decoding tests |
| skills/clickhouse-js-node-rowbinary-parser/tests/Polygon.test.ts | Geo Polygon decoding tests |
| skills/clickhouse-js-node-rowbinary-parser/tests/MultiLineString.test.ts | Geo MultiLineString decoding tests |
| skills/clickhouse-js-node-rowbinary-parser/tests/MultiPolygon.test.ts | Geo MultiPolygon decoding tests |
| skills/clickhouse-js-node-rowbinary-parser/tests/Geometry.test.ts | Geo Geometry variant decoding tests |
| README.md | Document rowbinary as 4th package |
| packages/client-common/package.json | Bump common package version to 1.23.0 |
| packages/client-common/src/version.ts | Bump common runtime version string |
| packages/client-node/package.json | Bump node client version + register new skill + prepack pruning |
| packages/client-node/src/version.ts | Bump node runtime version string |
| packages/client-web/package.json | Bump web client version + common dependency |
| packages/client-web/src/version.ts | Bump web runtime version string |
| package-lock.json | Update lockfile versions for 1.23.0 packages |
| CHANGELOG.md | Add 1.23.0 entry for rowbinary library/skill |
| .github/workflows/tests-node.yml | CI trigger path filter adjustments |
| .github/workflows/tests-web.yml | CI trigger path filter adjustments |
| .github/workflows/tests-bun.yml | CI trigger path filter adjustments |
| .github/workflows/tests-oss-dependents.yml | CI trigger path filter adjustments |
| .github/workflows/examples.yml | CI trigger path filter adjustments |
| .github/workflows/tests-skill-rowbinary-parser.yml | New workflow for rowbinary skill CI |
| demo/logs/package.json | New Next.js demo package + dependency on vendored tarball |
| demo/logs/package-lock.json | Demo lockfile |
| demo/logs/tsconfig.json | Demo TS config |
| demo/logs/next.config.mjs | Demo Next config (serverExternalPackages) |
| demo/logs/docker-compose.yml | Demo ClickHouse docker compose |
| demo/logs/README.md | Demo documentation |
| demo/logs/.gitignore | Demo gitignore |
| demo/logs/screenshot.png | Demo screenshot asset |
| demo/logs/vendor/clickhouse-rowbinary-0.1.0.tgz | Vendored rowbinary tarball used by the demo |
| demo/logs/scripts/seed.mjs | Demo DB seeder script |
| demo/logs/lib/clickhouse.ts | Demo fetch-based ClickHouse HTTP helper |
| demo/logs/lib/logs.ts | Demo RowBinary decoding + paging logic |
| demo/logs/app/layout.tsx | Demo app root layout |
| demo/logs/app/page.tsx | Demo server-rendered logs page |
| demo/logs/app/globals.css | Demo styling |
Files not reviewed (2)
- demo/logs/package-lock.json: Generated file
- skills/clickhouse-js-node-rowbinary-parser/package-lock.json: Generated file
Comment on lines
+18
to
+23
| - "docker-compose.yml" | ||
| - "vitest.node.config.ts" | ||
| - "vitest.node.setup.ts" | ||
| - "vitest.web.config.ts" | ||
| - "vitest.web.setup.ts" | ||
| - ".github/workflows/tests-node.yml" |
Comment on lines
+33
to
+38
| - "docker-compose.yml" | ||
| - "vitest.node.config.ts" | ||
| - "vitest.node.setup.ts" | ||
| - "vitest.web.config.ts" | ||
| - "vitest.web.setup.ts" | ||
| - ".github/workflows/tests-node.yml" |
Comment on lines
+18
to
+23
| - "docker-compose.yml" | ||
| - "vitest.node.config.ts" | ||
| - "vitest.node.setup.ts" | ||
| - "vitest.web.config.ts" | ||
| - "vitest.web.setup.ts" | ||
| - ".github/workflows/tests-web.yml" |
Comment on lines
+33
to
+38
| - "docker-compose.yml" | ||
| - "vitest.node.config.ts" | ||
| - "vitest.node.setup.ts" | ||
| - "vitest.web.config.ts" | ||
| - "vitest.web.setup.ts" | ||
| - ".github/workflows/tests-web.yml" |
Comment on lines
+18
to
+23
| - "docker-compose.yml" | ||
| - "vitest.node.config.ts" | ||
| - "vitest.node.setup.ts" | ||
| - "vitest.web.config.ts" | ||
| - "vitest.web.setup.ts" | ||
| - ".github/workflows/tests-bun.yml" |
Comment on lines
+33
to
+38
| - "docker-compose.yml" | ||
| - "vitest.node.config.ts" | ||
| - "vitest.node.setup.ts" | ||
| - "vitest.web.config.ts" | ||
| - "vitest.web.setup.ts" | ||
| - ".github/workflows/tests-oss-dependents.yml" |
Comment on lines
+19
to
+24
| - "docker-compose.yml" | ||
| - "vitest.node.config.ts" | ||
| - "vitest.node.setup.ts" | ||
| - "vitest.web.config.ts" | ||
| - "vitest.web.setup.ts" | ||
| - ".github/workflows/examples.yml" |
Comment on lines
+35
to
+40
| - "docker-compose.yml" | ||
| - "vitest.node.config.ts" | ||
| - "vitest.node.setup.ts" | ||
| - "vitest.web.config.ts" | ||
| - "vitest.web.setup.ts" | ||
| - ".github/workflows/examples.yml" |
| "start": "next start -p 3000" | ||
| }, | ||
| "dependencies": { | ||
| "@clickhouse/rowbinary": "file:./vendor/clickhouse-rowbinary-0.1.0.tgz", |
Comment on lines
+84
to
+96
| vendor/ | ||
| clickhouse-rowbinary-0.1.0.tgz the packed library this demo installs | ||
| ``` | ||
|
|
||
| ## Updating the library | ||
|
|
||
| This app installs `@clickhouse/rowbinary` from the packed tarball in `vendor/`. | ||
| To pick up changes you make in the parent package, repack and reinstall — from | ||
| the package root (`../../`): | ||
|
|
||
| ```bash | ||
| npm run build && npm pack | ||
| cp clickhouse-rowbinary-*.tgz demo/logs/vendor/clickhouse-rowbinary-0.1.0.tgz |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A short description of the changes with a link to an open issue.
Checklist
Delete items not relevant to your PR: