You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
⚠️ In quarantine for some time, e.g. awaits @typescript-eslint/eslint-plugin support for v6. Isn't it redundant since there's a concurrent ""typescript-eslint": "^8""? See #943
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
Thanks for the proactive upgrade! The PR is clean and minimal (just package.json + yarn.lock). The PR description is honest about the risk, but digging into the lock file surfaces a concrete compatibility blocker.
🚨 Must Fix
@typescript-eslint peer dependency incompatibility: Both typescript-eslint@8.52.0 and @typescript-eslint/eslint-plugin@8.57.2 declare typescript: ">=4.8.4 <6.0.0" in their peer dependencies — TypeScript 6 is explicitly excluded. This is the risk the PR description flags, and it's a real one: linting may fail at CI or silently regress (type-aware rules broken).
Support for TypeScript 6 lands in typescript-eslint@v9 (currently in beta). Until then, merging this will produce peer dependency warnings at minimum and potentially broken type-aware lint rules at worst.
Version split between typescript-eslint and @typescript-eslint/eslint-plugin: The meta package typescript-eslint@^8 resolves to 8.52.0, but @typescript-eslint/eslint-plugin is pinned separately at ^8.57.2. The meta package pins its own sub-packages at 8.52.0, so you end up with two different versions installed side-by-side. These should be kept in sync to avoid rule/parser mismatches.
💡 Suggestions
Consider holding this PR open (as the "in quarantine" note implies) and tracking typescript-eslint v9 beta → stable. Once typescript-eslint@^9 ships with TypeScript 6 support, a single coordinated bump of both typescript and typescript-eslint would land cleanly.
If you want to unblock experimentation locally, you can add a resolutions field in package.json to force the TypeScript version and suppress the peer dep warning — but that's not a substitute for actual upstream support.
The TypeScript 6 upgrade itself is exactly right; the blocker is purely the linting toolchain not yet catching up. 🙌
Built from commit: 45ec8621f77b40187a458865a00c6c8dab18f754
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why?
Upgrade Typescript to latest release v6 as announced https://devblogs.microsoft.com/typescript/announcing-typescript-6-0
@typescript-eslint/eslint-pluginsupport for v6. Isn't it redundant since there's a concurrent ""typescript-eslint": "^8""? See #943How?
Preview?
N/A